Skip to content

Consider SHORTNAME and shortname equal as hostname #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Consider SHORTNAME and shortname equal as hostname #329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/openssl/ssl.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ def verify_hostname(hostname, san) # :nodoc:
san_parts = san.downcase.split(".")

# TODO: this behavior should probably be more strict
return san == hostname if san_parts.size < 2
return san.downcase == hostname.downcase if san_parts.size < 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ssl.rb is mostly copied from openssl gem: https://github.com/ruby/openssl/blob/master/lib/openssl/ssl.rb#L317

you maybe want to post this upstream first, ideally with an actual test-case.


# Matching is case-insensitive.
host_parts = hostname.downcase.split(".")
Expand Down