Consider SHORTNAME and shortname equal as hostname #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to be no reason to consider a local hostname as case sensitive when other hostnames are compared case insensitive. If the behavior needs to be more strict it would be good to document in what way it is more strict.
kares
reviewed
Mar 28, 2025
| @@ -314,7 +314,7 @@ def verify_hostname(hostname, san) # :nodoc: | |||
| san_parts = san.downcase.split(".") | |||
|
|
|||
| # TODO: this behavior should probably be more strict | |||
| return san == hostname if san_parts.size < 2 | |||
| return san.downcase == hostname.downcase if san_parts.size < 2 | |||
There was a problem hiding this comment.
ssl.rb is mostly copied from openssl gem: https://github.com/ruby/openssl/blob/master/lib/openssl/ssl.rb#L317
you maybe want to post this upstream first, ideally with an actual test-case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be no reason to consider a local hostname as case sensitive when other hostnames are compared case insensitive.
If the behavior needs to be more strict it would be good to document in what way it is more strict than qualified domain names.