Use new sets only in mango #5510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
We already use new ones everywhere else and when switching to OTP 28 we got a bunch of failure do to various order changes, so make sure to use new ones everywhere. Moreover, do not rely on implementation order of `sets:to_list()`, but sort the result to produce deterministic results regardless of the internal representation.
nickva
force-pushed
the
use-new-sets-only
branch
from
974280c to
09ef100
Compare
|
This is related to the effort to enable OTP 28 compatibility #5507 |
pgj
reviewed
Apr 23, 2025
| @@ -583,6 +585,9 @@ ddoc_name(<<"_design/", Name/binary>>) -> | |||
| ddoc_name(Name) -> | |||
| Name. | |||
|
|
|||
| set_from_list(KVs) -> | |||
There was a problem hiding this comment.
Would not it be better to move this definition to some shared utility module instead of duplicating its definition in multiple modules? One could include a similar wrapper for sets:new([{version, 2}]) (as e.g. set_new/0) to extend consistency to the creation of sets.
There was a problem hiding this comment.
Yeah, you're right, it's one line only but it's repeated 4 times, a util function would be nicer here.
nickva
added a commit
that referenced
this pull request
Apr 23, 2025
With OTP 28 sets switchd to using version 2 by default. That caused various tests to fail, as Jan discovered in #5507 In the previous PR #5510 we switched few mango instances to use a helper utility, but it was repeated a few times and Gábor made a good suggestion to use utility functions instead, so that's what this PR does. But it does it for the whole code base. Once we're post OTP 28 we can remove the utility and just use plain set functions.
nickva
added a commit
that referenced
this pull request
Apr 23, 2025
With OTP 28 sets switchd to using version 2 by default. That caused various tests to fail, as Jan discovered in #5507 In the previous PR #5510 we switched few mango instances to use a helper utility, but it was repeated a few times and Gábor made a good suggestion to use utility functions instead, so that's what this PR does. But it does it for the whole code base. Once we're post OTP 28 we can remove the utility and just use plain set functions.
nickva
added a commit
that referenced
this pull request
Apr 23, 2025
With OTP 28 sets switchd to using version 2 by default. That caused various tests to fail, as Jan discovered in #5507 In the previous PR #5510 we switched few mango instances to use a helper utility, but it was repeated a few times and Gábor made a good suggestion to use utility functions instead, so that's what this PR does. But it does it for the whole code base. Once we're post OTP 28 we can remove the utility and just use plain set functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already use new ones everywhere else and when switching to OTP 28 we got a bunch of failure do to various order changes, so make sure to use new ones everywhere.
Moreover, do not rely on implementation order of
sets:to_list(), but sort the result to produce deterministic results regardless of the internal representation.