Use new sets everywhere #5514
Merged
Use new sets everywhere #5514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With OTP 28 sets switchd to using version 2 by default. That caused various tests to fail, as Jan discovered in #5507 In the previous PR #5510 we switched few mango instances to use a helper utility, but it was repeated a few times and Gábor made a good suggestion to use utility functions instead, so that's what this PR does. But it does it for the whole code base. Once we're post OTP 28 we can remove the utility and just use plain set functions.
nickva
force-pushed
the
improve-new-sets
branch
from
daa3a59 to
70b82a7
Compare
jaydoane
approved these changes
Apr 23, 2025
| % use version 2, which is also more performant | ||
| % | ||
| % Remove after OTP >= 28 and switch to plain sets:new/0 and sets:from_list/1 | ||
|
|
There was a problem hiding this comment.
You could DRY this out a little:
Suggested change
| -define(V2, {version, 2}). |
There was a problem hiding this comment.
That could work, but it's only in two places and they are next to each other. The rest of the code now uses the util functions.
I debated initially using just macros (?NEW_SET() and ?SET_FROM_LIST() that would mean having to use the include couch_db.hrl in a few more places so settled on a plain utility function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With OTP 28 sets switched to using version 2 by default. That caused various tests to fail, as Jan discovered in #5507
In the previous PR #5510 we switched few mango instances to use a helper utility, but it was repeated a few times and Gábor made a good suggestion to use utility functions instead, so that's what this PR does. But it does it for the whole code base.
Once we're post OTP 28 we can remove the utility and just use plain set functions.