Skip to content

Migrate to zarr-python 3 #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Migrate to zarr-python 3 #49

wants to merge 10 commits into from

Conversation

dstansby
Copy link
Collaborator

@dstansby dstansby commented Apr 3, 2025

This is a work in progress, switching exisiting code from zarr-python 2 to zarr-python 3. I will pick this up again at some point, or someone else is welcome to pick it up and run with it to finish it.

@dstansby
Copy link
Collaborator Author

@d-v-b I think this is all good for review now. The only thing broken is the docstests, because memory stores have a different name each time they're printed (because the memory address changes). I'm not too sure the best way to fix this...

@dstansby dstansby marked this pull request as ready for review April 16, 2025 13:38
@d-v-b
Copy link
Collaborator

d-v-b commented Apr 19, 2025

@d-v-b I think this is all good for review now. The only thing broken is the docstests, because memory stores have a different name each time they're printed (because the memory address changes). I'm not too sure the best way to fix this...

I think the best solution would be for zarr-python to stop using the memory address in the repr for memory stores :)

d-v-b
d-v-b reviewed Apr 19, 2025
View reviewed changes
src/pydantic_zarr/v2.py
dimension_separator=array._dimension_separator,
compressor=array.compressor,
dimension_separator=array.metadata.dimension_separator,
compressor=array.compressors[0].get_config(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this will fail if the array has no compressors

@d-v-b
Copy link
Collaborator

d-v-b commented Apr 19, 2025

is it OK if I make commits against dstansby:zarr-python-3 branch? I think there are some changes to the v3 logic I'd like to add

@dstansby
Copy link
Collaborator Author

Yeah go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-v-b d-v-b d-v-b left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dstansby @d-v-b