Skip to content

fix: report workflow #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 2, 2022
Merged

fix: report workflow #1148

merged 3 commits into from
Oct 2, 2022

Conversation

tsuyoshicho
Copy link
Contributor

@tsuyoshicho tsuyoshicho commented Oct 2, 2022

close #1147

差分レポートを修正

いままで、デフォルトで clone されている内容から差分を生成していた。
おそらくデフォルトの clone がされなくなったために失敗するようになった。

#1134 での変更で対象が上手く選択できなくなった。

workflow で clone している work 以下を正しく利用するように変更


step: Checkout vimdoc-ja-working にて

https://github.com/vim-jp/vimdoc-ja-working/actions/runs/3165169613

Run actions/checkout@v2
with:
path: work
repository: vim-jp/vimdoc-ja-working

/usr/bin/git config --global --add safe.directory /home/runner/work/vimdoc-ja-working/vimdoc-ja-working/work

なのに

step: Build report の get_doc_info.sh
での定義が

old_doc_dir=${GITHUB_WORKSPACE}/vimdoc-ja-working/en

これにより

ls: cannot access '/home/runner/work/vimdoc-ja-working/vimdoc-ja-working/vimdoc-ja-working/en/*.txt': No such file or directory

という失敗

@tsuyoshicho tsuyoshicho requested review from h-east and k-takata October 2, 2022 07:28
@tsuyoshicho tsuyoshicho self-assigned this Oct 2, 2022
@h-east
Copy link
Member

h-east commented Oct 2, 2022

すんません。#1134 を何も考えずにmergeしちゃいました 🙇‍♂️

@tsuyoshicho
Copy link
Contributor Author

あ、とすると自分も間違えてますね...なおします。

@@ -7,7 +7,7 @@

# 自分の環境にあわせて変更する必要がある
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コメントも変えた方がいいかもですね。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3行目のコメントとここのパスが違っていたから「修正しよう」と思い立ったのだと思いますんで、よしなに変更ください。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

たしかに、手直ししておきます。

@tsuyoshicho tsuyoshicho requested a review from h-east October 2, 2022 09:31
@h-east h-east merged commit 2f1c4e2 into vim-jp:master Oct 2, 2022
@h-east
Copy link
Member

h-east commented Oct 2, 2022

Thanks for your follow up:+1:

@tsuyoshicho tsuyoshicho deleted the fix/report branch October 2, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

更新差分 Issue の更新が失敗している
2 participants