fix(pretty-dom): Ensure safe process.env access #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs testing-library#413 refs testing-library#161 Not all environments (particularly the browser, where testing via tools like Karma occurs) have access to the `process` variable. There is already checking to ensure that its member properties have fallbacks, and this ensures that if it is simply unavailable the same fallback occurs.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 87df57a:
|
Codecov Report
@@ Coverage Diff @@
## master #431 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 22 22
Lines 374 374
Branches 87 87
=====================================
Hits 374 374
Continue to review full report at Codecov.
|
eps1lon
changed the title
eps1lon
approved these changes
Jan 27, 2020
kentcdodds
approved these changes
Jan 28, 2020
|
@all-contributors please add @Westbrook for code |
|
I've put up a pull request to add @Westbrook! 🎉 |
|
🎉 This PR is included in version 6.11.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #413
refs #161
What:
Not all environments (particularly the browser, where testing via tools like Karma occurs) have access to the
processvariable. There is already checking to ensure that its member properties have fallbacks, and this ensures that if it is simply unavailable the same fallback occurs.Why:
I'd like to begin the work of supporting Karma and web components.
How:
Extra test for
process.Checklist:
docs site
DefinitelyTyped