Skip to content

Review compiler options for Clang and GCC #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Apr 1, 2025

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

@jviotti jviotti force-pushed the compiler-options-review branch from c804ecb to aec701a Compare April 1, 2025 18:49
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti force-pushed the compiler-options-review branch from aec701a to 1339fec Compare April 1, 2025 18:53
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: 1339fec Previous: 639d617 Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 6.930082589285799 ns/iter 7.6730812157441335 ns/iter 0.90
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 6.885331473214557 ns/iter 6.890097321428154 ns/iter 1.00
Regex_Period_Asterisk 6.836558005193386 ns/iter 6.8894062499997535 ns/iter 0.99
Regex_Group_Period_Asterisk_Group 7.067041294642909 ns/iter 6.902935267856235 ns/iter 1.02
Regex_Period_Plus 7.547385044643917 ns/iter 7.38385825892886 ns/iter 1.02
Regex_Period 7.465096841673212 ns/iter 7.262488839285502 ns/iter 1.03
Regex_Caret_Period_Plus_Dollar 7.423008449003341 ns/iter 7.40875669642855 ns/iter 1.00
Regex_Caret_Group_Period_Plus_Group_Dollar 7.14167299107084 ns/iter 7.528319196428158 ns/iter 0.95
Regex_Caret_Period_Asterisk_Dollar 7.040430803571292 ns/iter 6.833976562499495 ns/iter 1.03
Regex_Caret_Group_Period_Asterisk_Group_Dollar 6.917770089285926 ns/iter 7.157535714285806 ns/iter 0.97
Regex_Caret_X_Hyphen 11.871417857142726 ns/iter 14.276392570193874 ns/iter 0.83
Regex_Period_Md_Dollar 138.13516794039523 ns/iter 136.63976785713723 ns/iter 1.01
Regex_Caret_Slash_Period_Asterisk 10.559778571429693 ns/iter 10.485517187500903 ns/iter 1.01
Regex_Caret_Period_Range_Dollar 7.551502232142785 ns/iter 7.475825892857556 ns/iter 1.01
Regex_Nested_Backtrack 1177.6676785714812 ns/iter 596.160982142838 ns/iter 1.98
JSON_Array_Of_Objects_Unique 407.8385353643519 ns/iter 404.70489711135053 ns/iter 1.01
JSON_Parse_1 78098.25900629572 ns/iter 79154.39935717692 ns/iter 0.99
JSON_Fast_Hash_Helm_Chart_Lock 54.377340000007734 ns/iter 54.906240000002526 ns/iter 0.99
JSON_Equality_Helm_Chart_Lock 188.7254166557207 ns/iter 183.1919092135446 ns/iter 1.03
JSON_String_Equal/10 9.032024999999777 ns/iter 8.988415138445236 ns/iter 1.00
JSON_String_Equal/100 9.905003125000533 ns/iter 10.002021875001432 ns/iter 0.99
JSON_String_Equal_Small_By_Perfect_Hash/10 2.1702884374999343 ns/iter 2.1705159374999283 ns/iter 1.00
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 15.348776236503932 ns/iter 15.946247767857358 ns/iter 0.96
JSON_String_Fast_Hash/10 3.4088985206981977 ns/iter 3.4144171814029876 ns/iter 1.00
JSON_String_Fast_Hash/100 3.4085945474844968 ns/iter 3.407972817825184 ns/iter 1.00
JSON_String_Key_Hash/10 8.660128086338863 ns/iter 8.058986607143279 ns/iter 1.07
JSON_String_Key_Hash/100 3.7115176950934172 ns/iter 3.732725350477162 ns/iter 0.99
JSON_Object_Defines_Miss_Same_Length 4.642988180006151 ns/iter 4.665392466222697 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Small 4.658864876954184 ns/iter 4.6512596085960185 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Large 3.775354278972517 ns/iter 3.7243510647780225 ns/iter 1.01
Pointer_Object_Traverse 50.097589285716786 ns/iter 49.090973214284915 ns/iter 1.02
Pointer_Object_Try_Traverse 64.75673214285597 ns/iter 65.57932142858444 ns/iter 0.99
Pointer_Push_Back_Pointer_To_Weak_Pointer 188.2619632376883 ns/iter 178.47209007626756 ns/iter 1.05
Schema_Frame_OMC_Instances 482542700.00001043 ns/iter 497802500.00003433 ns/iter 0.97
Schema_Frame_OMC_References 350295499.9999588 ns/iter 359034100.00003076 ns/iter 0.98
Schema_Frame_OMC_Locations 341414899.9999611 ns/iter 347989199.9999154 ns/iter 0.98
Schema_Bundle_Meta_2020_12 16347862.22222778 ns/iter 16698180.487787241 ns/iter 0.98

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: 1339fec Previous: 639d617 Ratio
Schema_Frame_OMC_Instances 225378845.6666825 ns/iter 215916759.66665962 ns/iter 1.04
Schema_Frame_OMC_References 148649622.3999893 ns/iter 142898726.60001493 ns/iter 1.04
Schema_Frame_OMC_Locations 144067743.00000507 ns/iter 138602162.99999592 ns/iter 1.04
Schema_Bundle_Meta_2020_12 7132738.938781001 ns/iter 6957671.239996444 ns/iter 1.03
Pointer_Object_Traverse 48.96240288617428 ns/iter 47.26963303432434 ns/iter 1.04
Pointer_Object_Try_Traverse 22.444207888172237 ns/iter 23.495456933743558 ns/iter 0.96
Pointer_Push_Back_Pointer_To_Weak_Pointer 176.49444818316977 ns/iter 163.52160887545764 ns/iter 1.08
JSON_Array_Of_Objects_Unique 377.601524058159 ns/iter 368.7261870361951 ns/iter 1.02
JSON_Parse_1 34823.69285749516 ns/iter 33424.243310512575 ns/iter 1.04
JSON_Fast_Hash_Helm_Chart_Lock 63.024000452723776 ns/iter 63.10360919779329 ns/iter 1.00
JSON_Equality_Helm_Chart_Lock 148.64869424696025 ns/iter 148.0807976478677 ns/iter 1.00
JSON_String_Equal/10 5.989418821228048 ns/iter 5.407126811097978 ns/iter 1.11
JSON_String_Equal/100 6.6145690510600845 ns/iter 6.0438261243483975 ns/iter 1.09
JSON_String_Equal_Small_By_Perfect_Hash/10 0.9342315739972317 ns/iter 0.9360593121669456 ns/iter 1.00
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 19.293055299334068 ns/iter 19.264535653572974 ns/iter 1.00
JSON_String_Fast_Hash/10 0.9329707239991972 ns/iter 0.9390124130401155 ns/iter 0.99
JSON_String_Fast_Hash/100 0.9328694305897223 ns/iter 0.9326743048544069 ns/iter 1.00
JSON_String_Key_Hash/10 1.246056441317118 ns/iter 1.2452469048070702 ns/iter 1.00
JSON_String_Key_Hash/100 2.1778686926980986 ns/iter 2.0322366073761073 ns/iter 1.07
JSON_Object_Defines_Miss_Same_Length 2.8039511956119587 ns/iter 2.8363155064991785 ns/iter 0.99
JSON_Object_Defines_Miss_Too_Small 2.490842636449965 ns/iter 2.4880752900017455 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Large 2.800080578091239 ns/iter 2.4902921322852154 ns/iter 1.12
Regex_Lower_S_Or_Upper_S_Asterisk 2.7993107694502126 ns/iter 2.797492510220007 ns/iter 1.00
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 3.115040803267106 ns/iter 3.1119907181541286 ns/iter 1.00
Regex_Period_Asterisk 3.108222017176106 ns/iter 3.108016997933928 ns/iter 1.00
Regex_Group_Period_Asterisk_Group 3.115489838895769 ns/iter 3.1125218157634187 ns/iter 1.00
Regex_Period_Plus 3.1103173430859226 ns/iter 3.1079876766572987 ns/iter 1.00
Regex_Period 3.1094344673817345 ns/iter 3.112464033617913 ns/iter 1.00
Regex_Caret_Period_Plus_Dollar 3.1090801877296865 ns/iter 3.1079326858305887 ns/iter 1.00
Regex_Caret_Group_Period_Plus_Group_Dollar 3.108865783067565 ns/iter 3.108710393326513 ns/iter 1.00
Regex_Caret_Period_Asterisk_Dollar 4.039889860766467 ns/iter 3.8948810017653943 ns/iter 1.04
Regex_Caret_Group_Period_Asterisk_Group_Dollar 4.045014765070714 ns/iter 3.115636413707167 ns/iter 1.30
Regex_Caret_X_Hyphen 13.180476550409296 ns/iter 13.118568353046323 ns/iter 1.00
Regex_Period_Md_Dollar 116.43109786933431 ns/iter 88.51360165020337 ns/iter 1.32
Regex_Caret_Slash_Period_Asterisk 9.017956743084387 ns/iter 7.786301103717144 ns/iter 1.16
Regex_Caret_Period_Range_Dollar 4.042746765394814 ns/iter 4.049646471234221 ns/iter 1.00
Regex_Nested_Backtrack 860.9943203252207 ns/iter 819.2116185387041 ns/iter 1.05

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant