[Monorepo] Move config files #3487
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-piasecki
reviewed
Apr 18, 2025
Comment on lines
13
to
23
| "@types/react": "^19.0.12", | ||
| "@types/react-test-renderer": "^19.0.0", | ||
| "@typescript-eslint/eslint-plugin": "^4.33.0", | ||
| "@typescript-eslint/parser": "^4.33.0", | ||
| "babel-plugin-module-resolver": "^5.0.2", | ||
| "clang-format": "^1.8.0", | ||
| "eslint": "^7.32.0", | ||
| "eslint-config-satya164": "^3.1.8", | ||
| "eslint-import-resolver-babel-module": "^5.2.0", | ||
| "eslint-plugin-jest": "^26.0.0", | ||
| "eslint-plugin-prettier": "^5.2.1", | ||
| "expo": "^35.0.1", | ||
| "husky": "^8.0.1", | ||
| "jest": "^28.1.0", | ||
| "lint-staged": "^12.3.2", | ||
| "madge": "^6.1.0", | ||
| "prettier": "3.3.3", | ||
| "react": "19.0.0", | ||
| "react-native": "0.78.0", | ||
| "react-native-builder-bob": "^0.39.0", | ||
| "react-native-reanimated": "^3.12.0", | ||
| "react-test-renderer": "19.0.0", | ||
| "release-it": "^13.6.5", | ||
| "typescript": "5.0.4" |
There was a problem hiding this comment.
Are dependencies needed at all in the root?
There was a problem hiding this comment.
Prettier, eslint, tsconfig.json, husky etc. are still useful to work on the files in the root. Also, you probably want the root to dictate what version of typescript, prettier etc. is used.
There was a problem hiding this comment.
Do they also need to be set in the packages?
j-piasecki
approved these changes
Apr 24, 2025
There was a problem hiding this comment.
Take a look at #3487 (comment). If the answer is yes, then go ahead with merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves config files to root level in monorepo.
Note
preparewas changed topostinstall, however this change is already onmainso it shouldn't be critical.Test plan