Skip to content

Customizable buffer type (proof of concept) #2912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions serde/src/de/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1223,6 +1223,12 @@ pub trait Deserializer<'de>: Sized {
true
}

///
fn deserialize_buffer(self) -> Result<impl Buffer<'de, Error = Self::Error>, Self::Error> {
let content = crate::__private::de::Content::deserialize(self)?;
Ok(crate::__private::de::ContentDeserializer::new(content))
}

// Not public API.
#[cfg(all(not(no_serde_derive), any(feature = "std", feature = "alloc")))]
#[doc(hidden)]
Expand All @@ -1238,6 +1244,29 @@ pub trait Deserializer<'de>: Sized {
}
}

///
pub trait Buffer<'de> {
///
type Error: Error;

///
type OwnedDeserializer: Deserializer<'de, Error = Self::Error>;

///
type RefDeserializer<'a>: Deserializer<'de, Error = Self::Error> + Copy
where
'de: 'a,
Self: 'a;

///
fn owned_deserializer(self) -> Self::OwnedDeserializer;

///
fn ref_deserializer<'a>(&'a self) -> Self::RefDeserializer<'a>
where
'de: 'a;
}

////////////////////////////////////////////////////////////////////////////////

/// This trait represents a visitor that walks through a deserializer.
Expand Down Expand Up @@ -1892,6 +1921,14 @@ pub trait MapAccess<'de> {
fn size_hint(&self) -> Option<usize> {
None
}

///
fn next_value_buffer(
&mut self,
) -> Result<impl Buffer<'de, Error = Self::Error> + use<'de, Self>, Self::Error> {
let content = self.next_value::<crate::__private::de::Content>()?;
Ok(crate::__private::de::ContentDeserializer::new(content))
}
}

impl<'de, A> MapAccess<'de> for &mut A
Expand Down
1 change: 1 addition & 0 deletions serde/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@

////////////////////////////////////////////////////////////////////////////////

#![feature(precise_capturing_in_traits)]
// Serde types in rustdoc of other crates get linked to here.
#![doc(html_root_url = "https://docs.rs/serde/1.0.219")]
// Support using Serde without the standard library!
Expand Down
28 changes: 27 additions & 1 deletion serde/src/private/de.rs
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ mod content {
use crate::actually_private;
use crate::de::value::{MapDeserializer, SeqDeserializer};
use crate::de::{
self, size_hint, Deserialize, DeserializeSeed, Deserializer, EnumAccess, Expected,
self, size_hint, Buffer, Deserialize, DeserializeSeed, Deserializer, EnumAccess, Expected,
IgnoredAny, MapAccess, SeqAccess, Unexpected, Visitor,
};

Expand Down Expand Up @@ -324,6 +324,32 @@ mod content {
}
}

impl<'de, E> Buffer<'de> for ContentDeserializer<'de, E>
where
E: de::Error,
{
type Error = E;

type OwnedDeserializer = Self;

type RefDeserializer<'a>
= ContentRefDeserializer<'a, 'de, E>
where
'de: 'a,
E: 'a;

fn owned_deserializer(self) -> Self::OwnedDeserializer {
self
}

fn ref_deserializer<'a>(&'a self) -> Self::RefDeserializer<'a>
where
'de: 'a,
{
ContentRefDeserializer::new(&self.content)
}
}

/// Used to capture data in [`Content`] from other deserializers.
/// Cannot capture externally tagged enums, `i128` and `u128`.
struct ContentVisitor<'de> {
Expand Down
8 changes: 4 additions & 4 deletions serde_derive/src/de.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1669,12 +1669,12 @@ fn deserialize_adjacently_tagged_enum(
// First key is the content.
_serde::__private::Some(_serde::__private::de::TagOrContentField::Content) => {
// Buffer up the content.
let __content = _serde::de::MapAccess::next_value::<_serde::__private::de::Content>(&mut __map)?;
let __content = _serde::de::MapAccess::next_value_buffer(&mut __map)?;
// Visit the second key.
match #next_relevant_key {
// Second key is the tag.
_serde::__private::Some(_serde::__private::de::TagOrContentField::Tag) => {
let __deserializer = _serde::__private::de::ContentDeserializer::<__A::Error>::new(__content);
let __deserializer = _serde::de::Buffer::owned_deserializer(__content);
#finish_content_then_tag
}
// Second key is a duplicate of the content.
Expand Down Expand Up @@ -1789,8 +1789,8 @@ fn deserialize_untagged_enum_after(
});

quote_block! {
let __content = <_serde::__private::de::Content as _serde::Deserialize>::deserialize(__deserializer)?;
let __deserializer = _serde::__private::de::ContentRefDeserializer::<__D::Error>::new(&__content);
let __content = _serde::Deserializer::deserialize_buffer(__deserializer)?;
let __deserializer = _serde::de::Buffer::ref_deserializer(&__content);

#first_attempt

Expand Down
Loading