Skip to content

lvm: improve completions for lvremove #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −1
Open

lvm: improve completions for lvremove #1335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cd6911
fix(lvm): improve completions for `lvremove`
siteshwar Feb 18, 2025
e4bac86
test(lvremove): test generation of "/dev/mapper/"
akinomyoga Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion completions/lvm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ _comp_cmd_lvm__physicalvolumes()
_comp_cmd_lvm__logicalvolumes()
{
_comp_compgen_split -- "$(lvscan 2>/dev/null |
command sed -n -e "s|^.*'\(.*\)'.*$|\1|p")"
command sed -n -e "s|^.*'\(.*\)'.*$|\1|p") /dev/mapper/"
if [[ $cur == /dev/mapper/* ]]; then
_comp_compgen -a filedir
local i
Expand Down
4 changes: 4 additions & 0 deletions test/t/test_lvremove.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,7 @@ class TestLvremove:
)
def test_1(self, completion):
assert completion

@pytest.mark.complete("lvremove /dev/map")
def test_2(self, completion):
assert completion == "per/"