Skip to content

overhaul CI and publishing #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 19, 2024
Merged

overhaul CI and publishing #14

merged 7 commits into from
Dec 19, 2024

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Dec 18, 2024

  • replace Travis-CI with GitHub Actions
  • upgrade to sbt 1.x
  • remove sbt-scala-module (thereby dropping OSGi support)
  • publish with sbt-ci-release

fyi @lrytz

context: scala/scala#10888

@SethTisue SethTisue self-assigned this Dec 18, 2024
@SethTisue SethTisue changed the title replace Travis-CI with GitHub Actions replace Travis-CI with GitHub Actions; upgrade to sbt 1.x; remove OSGi Dec 18, 2024
@SethTisue SethTisue changed the title replace Travis-CI with GitHub Actions; upgrade to sbt 1.x; remove OSGi replace Travis-CI with GitHub Actions; upgrade to sbt 1.x; remove OSGi; publish with sbt-ci-release Dec 18, 2024
@SethTisue SethTisue marked this pull request as draft December 18, 2024 23:43
@SethTisue
Copy link
Member Author

SethTisue commented Dec 18, 2024

I'll need to customize sbt-dynver to get the right handling of tags; we want a tag such as s-9.7.1 to result in a version such as 9.7.1-scala-1. The old publishing setup had code for this: git.gitTagToVersionNumber := ...

see https://github.com/sbt/sbt-dynver?tab=readme-ov-file#custom-version-string

@SethTisue
Copy link
Member Author

SethTisue commented Dec 18, 2024

Also I ripped out sbt-scala-module as I'd rather have a self-contained build, but I need to make sure that everything we were getting from it gets duplicated here. For example setting organization.

see https://github.com/scala/sbt-scala-module/blob/main/src/main/scala/ScalaModulePlugin.scala

@SethTisue SethTisue changed the title replace Travis-CI with GitHub Actions; upgrade to sbt 1.x; remove OSGi; publish with sbt-ci-release replace Travis-CI with GitHub Actions; upgrade to sbt 1.x; remove sbt-scala-module and OSGi; publish with sbt-ci-release Dec 19, 2024
@SethTisue SethTisue marked this pull request as ready for review December 19, 2024 02:11
@SethTisue SethTisue marked this pull request as draft December 19, 2024 02:11
@SethTisue
Copy link
Member Author

decided to just make setting version a manual step

@SethTisue SethTisue marked this pull request as ready for review December 19, 2024 02:18
@SethTisue SethTisue changed the title replace Travis-CI with GitHub Actions; upgrade to sbt 1.x; remove sbt-scala-module and OSGi; publish with sbt-ci-release overhaul CI and publishing Dec 19, 2024
@SethTisue SethTisue merged commit b500ffb into s-9.7.1 Dec 19, 2024
2 checks passed
@SethTisue SethTisue deleted the bye-bye-travis-ci branch December 19, 2024 02:20
@SethTisue
Copy link
Member Author

perhaps this will need some further tweaking once I actually try to publish

@SethTisue
Copy link
Member Author

of course I had to do the usual rigmarole of generating a GPG key and adding the four secrets (as documented in sbt-ci-release readme) to our repo secrets, remembering to use our Sonatype user token and not our plain name/password

two tweaks so far:

  • add <developers> stuff, Sonatype requires it
  • remove a stray versionCheck that I cargo-culled into release.yml

that was enough for the publishing job to apparently succeed: https://github.com/scala/scala-asm/actions/runs/12405290988

but once it's on Maven Central I want to diff the JARs against scala-asm-9.7.0-2 to see if any unintended changes crept in

@SethTisue
Copy link
Member Author

it published: https://repo1.maven.org/maven2/org/scala-lang/modules/scala-asm/9.7.1-scala-1/

diffing the POMs, I don't know what this is about:

-    <packaging>bundle</packaging>
+    <packaging>jar</packaging>

the other diffs are just unimportant metadata differences

as for the JAR contents:

  • we are no longer generating the scala-asm.properties file that sbt-scala-module used to provide, but I really don't think we care
  • MANIFEST.MF no longer has the OSGi stuff, as expected

@SethTisue
Copy link
Member Author

diffing the POMs, I don't know what this is about:

-    <packaging>bundle</packaging>
+    <packaging>jar</packaging>

Oh, that's just a consequence of not doing OSGi anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant