-
Notifications
You must be signed in to change notification settings - Fork 7
overhaul CI and publishing #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'll need to customize sbt-dynver to get the right handling of tags; we want a tag such as see https://github.com/sbt/sbt-dynver?tab=readme-ov-file#custom-version-string |
Also I ripped out sbt-scala-module as I'd rather have a self-contained build, but I need to make sure that everything we were getting from it gets duplicated here. For example setting see https://github.com/scala/sbt-scala-module/blob/main/src/main/scala/ScalaModulePlugin.scala |
decided to just make setting |
perhaps this will need some further tweaking once I actually try to publish |
of course I had to do the usual rigmarole of generating a GPG key and adding the four secrets (as documented in sbt-ci-release readme) to our repo secrets, remembering to use our Sonatype user token and not our plain name/password two tweaks so far:
that was enough for the publishing job to apparently succeed: https://github.com/scala/scala-asm/actions/runs/12405290988 but once it's on Maven Central I want to diff the JARs against scala-asm-9.7.0-2 to see if any unintended changes crept in |
it published: https://repo1.maven.org/maven2/org/scala-lang/modules/scala-asm/9.7.1-scala-1/ diffing the POMs, I don't know what this is about:
the other diffs are just unimportant metadata differences as for the JAR contents:
|
Oh, that's just a consequence of not doing OSGi anymore. |
fyi @lrytz
context: scala/scala#10888