Skip to content

Moves the encoding call to improve output #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tomer-ds
Copy link

@tomer-ds tomer-ds commented Mar 6, 2023

No description provided.

@tomer-ds tomer-ds changed the title Moved the encoding call Moves the encoding call to improve output Mar 6, 2023
@saadmk11 saadmk11 self-requested a review March 6, 2023 07:36
@saadmk11
Copy link
Owner

Can you please re-base the branch? tests were failing.

@saadmk11
Copy link
Owner

I tried it out but seems like the problem still exists. Please let me know if I am wrong. :)

@ibexa-yuna
Copy link

ibexa-yuna commented Apr 24, 2023

I'm not sure that escaping is even required when you're using heredoc output, as long as HEREDOC string is unique.

As per github example: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#example-of-a-multiline-string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants