feat(build): add optional package-name parameter
#1486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stegayet
changed the title
package_name parameterpackage-name parameter
This commit adds optional `package_name` parameter, which defaults to Rust crate name.
stegayet
force-pushed
the
feat/add-package-name-optional-parameter
branch
from
bfc08c0 to
eda9685
Compare
stegayet
commented
Mar 30, 2025
Comment on lines
+128
to
+130
| /// The npm package name to use in package.json, if any. | ||
| #[clap(long = "package-name", short = 'p')] | ||
| pub package_name: Option<String>, |
There was a problem hiding this comment.
I don't feel strongly about parameter name, open to suggestions!
|
Setting this PR as ready for review to get feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1485.
This commit adds optional
package-nameparameter, which defaults to Rust crate name.TODO:
out-name, which defaults to package name.Make sure these boxes are checked! 📦✅
rustfmtinstalledcargo fmton the code base before submitting✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨