Skip to content

fix(ruby-wasm): make Node able to load ruby+stdlib.wasm from dist/ #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2025

Conversation

tani
Copy link
Contributor

@tani tani commented Apr 20, 2025

Hi. Thank you for the great project. I change exports to "./dist/*.wasm": { "import": "./dist/*.wasm", "require": "./dist/*.wasm" } so sub‑path imports like @ruby/3.x-wasm-wasi/dist/ruby+stdlib.wasm resolve correctly.

- package.json
  - change `exports` to `"./dist/*.wasm": { "import": "./dist/*.wasm",
"require": "./dist/*.wasm" }`
    so sub‑path imports like `@ruby/3.x-wasm-wasi/dist/ruby+stdlib.wasm`
resolve correctly.
Copy link
Member

@kateinoigakukun kateinoigakukun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@kateinoigakukun kateinoigakukun merged commit 3c7606a into ruby:main Apr 20, 2025
33 checks passed
@tani
Copy link
Contributor Author

tani commented Apr 20, 2025

@kateinoigakukun Excuse me, I forget the patch for head packages. Please add them to head packages.

@kateinoigakukun
Copy link
Member

Applied 8a49b71

@tani
Copy link
Contributor Author

tani commented Apr 20, 2025

Thanks ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants