Add additional GHA settings #894
Open
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds some miscellaneous settings: - Set workflow default permissions as read-only (per security best practices) - Support merge queues - Support manual invocation (for debugging) - Make it so that starting another run of this workflow will cancel any ongoing runs for the same PR or branch (e.g., because a new push happened while the workflow is still running from a previous push)
Strilanc
approved these changes
Mar 4, 2025
|
If you can get merge queues working smoothly, I'd absolutely use them. Last time I tried I failed. |
Strilanc
approved these changes
Apr 5, 2025
| cancel-in-progress: true | ||
| group: ${{github.workflow}}-${{github.event.pull_request.number||github.ref}} | ||
|
|
||
| # Declare default permissions as read-only. |
There was a problem hiding this comment.
Permissions granted to workflow actions w.r.t. GITHUB_TOKEN.
| merge_group: | ||
| types: | ||
| - checks_requested | ||
| # Allow manual invocation – useful for debugging. |
There was a problem hiding this comment.
The comment refers to the next line, which is workflow_dispatch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some miscellaneous settings:
practices)
any ongoing runs for the same PR or branch (e.g., because a new push
happened while the workflow is still running from a previous push)