Increase wait and rerun amount for flaky network tests #13237
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichard26
added
the
skip news
This is also false. I'm not sure where the timeout is configured, but it seems like the timeout is ~270 seconds... which is pretty bad for a test suite.
https://github.com/pypa/pip/actions/runs/13472645497/job/37648026968?pr=13228 |
|
Whelp, I guess we can just mark this test not to run as part of the CI if we start seeing regular failures again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help with #13153
Launchpad is known to be occasionally flaky and the current wait / rerun amount isn't cutting it. If a retry can wait/try enough to complete it saves more time than rerunning a test.
It also doesn't significantly increase the amount of time to fail, assuming each timeout is a few seconds, and each wait is 5 seconds, we're still only talking about 35 seconds to fail.
If we continue to see more failures, it may be worth considering remove the launchpad tests, while keeping local bzr tests.