Fix infinite recursion when calling np.fix
#10248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are the relevant lines in the numpy code: https://github.com/numpy/numpy/blob/main/numpy/lib/_ufunclike_impl.py#L60-L61 |
|
could we add a small test? |
|
Added test @max-sixty . I'm looking through the other tests failure |
|
the test failures are likely unrelated — could we try merging in (fwiw I dalso don't see a test here — did it push correctly?) |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
dcherian
reviewed
Apr 28, 2025
dcherian
reviewed
Apr 28, 2025
dcherian
reviewed
Apr 28, 2025
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Apr 29, 2025
* main: Fix convert calendar on non-temporal data in datasets (pydata#10268) BinGrouper: reduce indirection (pydata#10270) Fix reduction by subset of grouper dimensions (pydata#10258) Shorten text repr for ``DataTree`` (pydata#10139) Fix benchmarks runners (pydata#10265) Fix infinite recursion when calling `np.fix` (pydata#10248) BinGrouper: Support setting labels when provided with IntervalIndex (pydata#10259) Avoid stacking when grouping by chunked array (pydata#10254) Improve alignment checks (pydata#10251) Update how-to-add-new-backend.rst (pydata#10240) Support extension array indexes (pydata#9671) Switch documentation to pydata-sphinx-theme (pydata#8708) Bump codecov/codecov-action from 5.4.0 to 5.4.2 in the actions group (pydata#10239)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
np.fixon a data array producesRecursionError: maximum recursion depth exceeded#9872