Skip to content

Add Nutils participants for turek-hron-fsi3 #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

gertjanvanzwieten
Copy link
Collaborator

This PR adds two Nutils participants for the turek-hron-fsi3 tutorial. The scripts are intentionally structured similar to our monolithic example so they can be compared side by side with https://examples.nutils.org/official-turek/.

Some notes:

  • The scripts are only tested in mutual coupling, so I don't know how they hold up with other participants. In particular I hope that traction is exchanged with the correct sign.
  • The script requires Nutils 9, which is the currently stable version.
  • The time step is set equal to the max_time_step_size, rather than the script having its own notion of a preferred time step. I'm not sure if that is idiomatic.

I hope you will find this a useful addition, let me know if anything needs changing!

@gertjanvanzwieten
Copy link
Collaborator Author

I ran both scripts through autopep8 -i but the style check is still failing. Please advise :)

@MakisH
Copy link
Member

MakisH commented Apr 28, 2025

I ran both scripts through autopep8 -i but the style check is still failing. Please advise :)

Thanks for the PR, @gertjanvanzwieten!
Maybe this is a version issue. We are using a pre-commit hook, which you could install to get the same version. This should not mess with the rest of your system.

@gertjanvanzwieten
Copy link
Collaborator Author

For some reason actions fail to kick in but I think the scripts are compliant now, changes are generated with pre-commit run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants