Skip to content

Fix: Build error occurs in navigation tutorial and Remove unnecessary button actions #3668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Ryota-Kurokawa
Copy link

Please refer to #3667

Fixed two point of tutorial

  • Could not build
  • Disabled button because using NavigationLink
  • incorrect use of ifLet

@iniko83
Copy link

iniko83 commented Apr 29, 2025

Hello!
English is not my native language, so I apologies for possible mistakes.

.buttonStyle(.borderless)
lay in wrong place, here is correct code:

Button {
  store.send(.deleteButtonTapped(id: contact.id))
} label: {
  Image(systemName: "trash")
    .foregroundColor(.red)
}
.buttonStyle(.borderless)

All other things are correct, I've done "meet TCA tutorial" today.

@Ryota-Kurokawa
Copy link
Author

Ryota-Kurokawa commented May 2, 2025

Hello! @iniko83

so, I could'n see any mistakes in the areas you pointed out. The answer will change depending on whether it is wrapped in a navigationLink or not. I would appreciate it if you could tell me the exact file for the part you pointed out.
My native is Japanese, so I apologies for possible mistakes too. Your comment was very helpful! Have an good catchup!

@Ryota-Kurokawa Ryota-Kurokawa force-pushed the fix/biuld-navigation-tutorial branch from 5b6b5a6 to 1143bec Compare May 2, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants