feat: add support for generating block names #12135
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR introduces a new
admin.generateBlockNamefunction to block configs which allows for generatingblockName's using data available via the doc and block data itself. This would allow users to generate these names via functions in config instead of defining customLabelcomponents for blocks.This PR also adds tests to ensure these block names are generated and to prevent overriding editor-authored block names, as well as docs changes.
Why?
To enable users to generate block names with functions defined in config.
How?
Adding a new
admin.generateBlockNamefunction, and threading it through toaddFieldStatePromise.ts.Fixes #12112 & addresses #4648
Demo:
Payload-generated-blockName-demo.webm