Add warning to .groupby when null keys would be dropped due to default dropna
#61351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tehunter
commented
Apr 24, 2025
Comment on lines
+64
to
+68
| _NULL_KEY_MESSAGE = ( | ||
| "`dropna` is not specified but grouper encountered null group keys. These keys " | ||
| "will be dropped from the result by default. To keep null keys, set `dropna=True`, " | ||
| "or to hide this warning and drop null keys, set `dropna=False`." | ||
| ) |
There was a problem hiding this comment.
Is this a standard approach for a warning message that could be hit from two lines of code?
Comment on lines
+489
to
+493
| @property | ||
| def dropna(self) -> bool: | ||
| if self._dropna is lib.no_default: | ||
| return True | ||
| return self._dropna |
There was a problem hiding this comment.
I know the implementation is trivial, but this is redundant with Grouper. I'm not sure we can get around it while still being a class property, but should the default value be referenced as a constant defined just once?
this will help with PDEP-11 (pandas-dev#53094) as an intermediate step to identify tests that will fail under the default value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataFrame.groupbydrops NA keys #61339doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.TODO:
codescheck approaches (codes.min()was about 3x faster).pivot_table/.stack/etc. (possibly in a follow-up PR?)