CPP Python bindings accuracy tests #287
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example works, but probably some missing parts.
as opposed to ModelBase as it was. So first it was ImageModel: ModelBase. Then ModelBase merged into ImageModel now rename ImageModel to BaseModel
OpenCV is using system opencv though...
It's ugly, but its just an example to show it works
Currently the rpath is set to a relative path to the site-packages of python for openvino (../openvino/libs). This is maybe not great. OpenCV does not seem to be an issue
…commits" This reverts commit 3fb1326.
This reverts commit ffc65ea.
Windows will come
Seems one model is causing an issue, either via segmentation fault if trying to catch error, or a nullptr tensor
Apparently scikit uses .gitignore to ignore what to add to the package
sovrasov
reviewed
Apr 15, 2025
| @@ -0,0 +1,16 @@ | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
Do we actually need that sample? Can be moved to tests as well
sovrasov
reviewed
Apr 16, 2025
| PYTHON_PATH $<TARGET_FILE_DIR:py_model_api> | ||
| DEPENDS py_model_api | ||
| set_target_properties(_vision_api PROPERTIES | ||
| LIBRARY_OUTPUT_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/src/vision_api" |
There was a problem hiding this comment.
Binaries are dumped to the source dir, which looks a bit weird. Can we use the build dir for that?
|
I see the labeler is failing, can updating to the latest master help? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test PR to check accuracy test using the new bindings (That pr will come later)