CI: Fix CI errors #135
Merged
CI: Fix CI errors #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kai-Striega
reviewed
Apr 16, 2025
There was a problem hiding this comment.
LGTM, thanks for the work @jorenham . I'm going to take a look at the test that's changed in a bit more detail (ideally over this weekend). But the changes look worth adding.
Co-authored-by: kai-striega <kaistriega@gmail.com>
Co-authored-by: kai-striega <kaistriega@gmail.com>
Kai-Striega
approved these changes
Apr 16, 2025
There was a problem hiding this comment.
Changes look good to me, happy to merge this once CI passes. Thanks @jorenham
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two
ruff/B905errors and a failing test on windows.