Don't re-compile RegExp in clone() #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has minimal effect on performance.
tjvr
changed the title
nathan
reviewed
Mar 18, 2017
moo.js
Outdated
| @@ -437,7 +432,7 @@ | |||
| var s = this.states[key] | |||
| map[key] = { | |||
| groups: s.groups, | |||
| regexp: new RegExp(s.regexp.source, s.regexp.flags), | |||
| regexp: s.regexp, | |||
| error: s.error, | |||
| } | |||
| } | |||
There was a problem hiding this comment.
I think you should actually be able to get rid of all the state-map copying code here, and just hand this.states to the new Lexer.
There was a problem hiding this comment.
You're right. Nice! :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #36
This has minimal effect on performance.