-
Notifications
You must be signed in to change notification settings - Fork 53
Add PowerShell script for Windows installation #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for the PR! |
Hey! I've made the changes to both the script and the README. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd love to get this merged too. We've got another PR on the main bash script which now supports windows if you have a bash shell. I also merged the ps1 script. This would bring the README in line with the rest.
README.md
Outdated
``` | ||
cargo install sendme | ||
``` | ||
|
||
## For Linux/MacOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update this to be ## For Linux/MacOS/Windows (bash)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README has been updated, but the issue for the powershell cmd persists as noted in [#320](n0-computer/iroh.computer#320). Any recommendations on how to resolve this?
@@ -0,0 +1,34 @@ | |||
$release_url = "https://api.github.com/repos/n0-computer/sendme/releases/latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And can we drop this as the script now lives in the iroh.computer
repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change the release_url to
$release_url = "https://api.github.com/repos/n0-computer/iroh.computer/releases/latest"
but iroh.computer repo doesnt have any releases and this script lies in that repo where it re-directs to the sendme repo.
Could you clarify what changes you're expecting me to make in this context?
This PR adds a PowerShell script (install-sendme.ps1) to allow Windows users to easily download and install the sendme tool, as well as add it to their PATH automatically.
Changes:
Notes:
Testing:
Tested the script on a Windows machine with the following outcomes:
New Installation Command (Once merged):