Add function Math.nearestInteger

[beutlich]

Cherry-picked from #3247 as proposed by #3247 (review).

[casella]

LGTM

[henrikt-ma]

More though seems needed on how to obtain a useable expression variability of the function result.

[henrikt-ma]

(Just restoring my Request changes after changing my mind back and forth.)

[HansOlsson]

The general idea is good, but when using it outside of functions it becomes messy.

It seems we need the annotation GenerateEvents=true and update such functions in terms of variability, e.g., along the lines of modelica/ModelicaSpecification#3610

[beutlich]

The general idea is good, but when using it outside of functions it becomes messy.

I removed the usage in block Modelica.Blocks.Math.RealToInteger. @casella @HansOlsson Please add your review again.

[HansOlsson]

LGTM.
Combined with modelica/ModelicaSpecification#3610 it will be generally useful.

One could possibly add "away from zero" already in description as the preferred method depends, https://en.wikipedia.org/wiki/Rounding (But it may also be too long.)

[beutlich]

One could possibly add "away from zero" already in description

Incorporated. Fell free to review this last change.

@henrikt-ma may I kindly ask for a second review. Thanks.

[henrikt-ma]

I don't think this can be accepted until it is relying on language features of a released version of the specification. According to current semantics, the output of this is a non-discrete-time Integer, which I'm pretty sure is not the intention.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.