Skip to content

Utilize constant EPSSIL in Modelica.Electrical.Spice3.Internal.Mos1.mos1ModelLineParamsInitEquations #4378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025

Conversation

beutlich
Copy link
Member

@beutlich beutlich commented Apr 2, 2024

Already utilized in other place.

@beutlich beutlich added the L: Electrical.Spice3 Issue addresses Modelica.Electrical.Spice3 label Apr 2, 2024
@HansOlsson
Copy link
Contributor

As noted in #4377 we might also document that epssil means epsilon (di-electric constant) for Silicon, and add a proper unit.

@beutlich beutlich requested a review from HansOlsson March 18, 2025 19:45
@beutlich
Copy link
Member Author

As noted in #4377 we might also document that epssil means epsilon (di-electric constant) for Silicon, and add a proper unit.

I updated the descriptions accordingly but will change the units of EPSSIL and EPSSOX in a separate PR once this PR gets merged, because this PR does not introduce any simulation relevant changes.

@beutlich beutlich force-pushed the utilize-constant branch 2 times, most recently from a787016 to 1037b29 Compare March 18, 2025 19:57
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.
There are also other changes we can do later.
However, e.g., using

constant SI.HeatCapacity CONSTboltz = Modelica.Constants.k; // J/K
constant SI.Charge CHARGE = Modelica.Constants.q; 
constant Real EPSSIL = 11.7 * Modelica.Constants.epsilon_0 "Absolute permittivity of silicon"; // F/m

requires testing.

Others that should be harmless are:

constant SI.Temperature CONSTCtoK = Modelica.Units.Conversions.from_degC(0);
constant SI.Temperature REFTEMP = Modelica.Units.Conversions.from_degC(27);
constant Real CONSTvt0(final unit="(J)/(A.s)") = Modelica.Constants.k * REFTEMP / CHARGE; // deg C

(And likely remove the final deg C.)

@beutlich beutlich added this to the MSL4.2.0 milestone Apr 16, 2025
@beutlich beutlich merged commit 6aa7331 into modelica:master Apr 16, 2025
11 checks passed
@beutlich beutlich deleted the utilize-constant branch April 16, 2025 20:05
@beutlich beutlich self-assigned this Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: Electrical.Spice3 Issue addresses Modelica.Electrical.Spice3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants