Skip to content

Change PaymentID from int to float #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

agustinglez
Copy link

@agustinglez agustinglez commented Oct 23, 2024

General changes

  • Change payment id from int to float in PaymentClient.php to be able to use large integers, greater than 10 digits. The int function of PHP may convert larger integers.

PR validation checklist:

  • Title and clear description of the PR
  • Tests of my functionality
  • Documentation of my functionality
  • Tests executed and passed
  • Branch Coverage >= 80%

@kelvincarvalhosilva
Copy link
Contributor

Hello @agustinglez

Thank you for your willingness to contribute!
An analysis of the proposed solution was carried out, but at the moment our team has decided not to integrate it into our product due to:

  • It is also necessary to change the return object resources/Payments from int to float.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants