Skip to content

fix: lua54 feature being forced #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025
Merged

fix: lua54 feature being forced #413

merged 1 commit into from
Apr 7, 2025

Conversation

makspll
Copy link
Owner

@makspll makspll commented Apr 7, 2025

Summary

This was me fat-fingering commits

Copy link
Contributor

github-actions bot commented Apr 7, 2025

🐰 Bencher Report

Branchfix/lua54-forced
Testbedlinux-gha
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)
Upper Boundary
nanoseconds (ns)
(Limit %)
component/access Lua📈 view plot
🚷 view threshold
3,450.10 ns
(-28.71%)Baseline: 4,839.32 ns
6,355.32 ns
(54.29%)
component/access Rhai📈 view plot
🚷 view threshold
6,180.20 ns
(-8.26%)Baseline: 6,736.88 ns
7,958.97 ns
(77.65%)
component/get Lua📈 view plot
🚷 view threshold
2,101.70 ns
(-26.25%)Baseline: 2,849.82 ns
3,573.41 ns
(58.82%)
component/get Rhai📈 view plot
🚷 view threshold
4,945.90 ns
(+0.02%)Baseline: 4,945.00 ns
5,973.05 ns
(82.80%)
conversions/Mut::from📈 view plot
🚷 view threshold
80.01 ns
(-39.22%)Baseline: 131.63 ns
241.63 ns
(33.11%)
conversions/Ref::from📈 view plot
🚷 view threshold
80.42 ns
(-37.90%)Baseline: 129.51 ns
239.23 ns
(33.62%)
conversions/ScriptValue::List📈 view plot
🚷 view threshold
264.34 ns
(-55.64%)Baseline: 595.92 ns
1,110.84 ns
(23.80%)
conversions/ScriptValue::Map📈 view plot
🚷 view threshold
1,273.00 ns
(-21.80%)Baseline: 1,627.80 ns
2,202.41 ns
(57.80%)
conversions/ScriptValue::Reference::from_into📈 view plot
🚷 view threshold
24.01 ns
(-40.52%)Baseline: 40.37 ns
60.61 ns
(39.61%)
conversions/Val::from_into📈 view plot
🚷 view threshold
273.23 ns
(-19.40%)Baseline: 338.99 ns
452.89 ns
(60.33%)
function/call 4 args Lua📈 view plot
🚷 view threshold
1,632.70 ns
(-21.49%)Baseline: 2,079.62 ns
2,505.59 ns
(65.16%)
function/call 4 args Rhai📈 view plot
🚷 view threshold
1,407.10 ns
(-21.68%)Baseline: 1,796.69 ns
2,214.07 ns
(63.55%)
function/call Lua📈 view plot
🚷 view threshold
233.60 ns
(-16.02%)Baseline: 278.15 ns
333.97 ns
(69.95%)
function/call Rhai📈 view plot
🚷 view threshold
461.52 ns
(-12.47%)Baseline: 527.25 ns
661.67 ns
(69.75%)
loading/empty Lua📈 view plot
🚷 view threshold
90,824.00 ns
(-5.20%)Baseline: 95,802.00 ns
120,320.99 ns
(75.48%)
loading/empty Rhai📈 view plot
🚷 view threshold
1,271,900.00 ns
(-3.15%)Baseline: 1,313,266.67 ns
1,521,227.86 ns
(83.61%)
math/vec mat ops Lua📈 view plot
🚷 view threshold
7,249.00 ns
(-7.18%)Baseline: 7,810.06 ns
9,111.40 ns
(79.56%)
math/vec mat ops Rhai📈 view plot
🚷 view threshold
6,058.90 ns
(-18.25%)Baseline: 7,411.84 ns
8,560.11 ns
(70.78%)
query/10 entities Lua📈 view plot
🚷 view threshold
17,706.00 ns
(-27.48%)Baseline: 24,415.03 ns
30,688.27 ns
(57.70%)
query/10 entities Rhai📈 view plot
🚷 view threshold
21,853.00 ns
(-10.13%)Baseline: 24,316.24 ns
28,414.74 ns
(76.91%)
query/100 entities Lua📈 view plot
🚷 view threshold
38,729.00 ns
(-21.83%)Baseline: 49,545.41 ns
61,029.84 ns
(63.46%)
query/100 entities Rhai📈 view plot
🚷 view threshold
35,461.00 ns
(-9.13%)Baseline: 39,024.81 ns
47,308.38 ns
(74.96%)
query/1000 entities Lua📈 view plot
🚷 view threshold
257,820.00 ns
(-17.52%)Baseline: 312,578.65 ns
381,820.20 ns
(67.52%)
query/1000 entities Rhai📈 view plot
🚷 view threshold
169,960.00 ns
(-21.95%)Baseline: 217,755.41 ns
296,758.18 ns
(57.27%)
reflection/10 Lua📈 view plot
🚷 view threshold
5,315.70 ns
(-18.59%)Baseline: 6,529.22 ns
7,557.85 ns
(70.33%)
reflection/10 Rhai📈 view plot
🚷 view threshold
14,710.00 ns
(-10.09%)Baseline: 16,360.97 ns
18,034.43 ns
(81.57%)
reflection/100 Lua📈 view plot
🚷 view threshold
46,300.00 ns
(-13.47%)Baseline: 53,505.81 ns
60,260.13 ns
(76.83%)
reflection/100 Rhai📈 view plot
🚷 view threshold
706,200.00 ns
(-4.59%)Baseline: 740,185.68 ns
872,244.43 ns
(80.96%)
resource/access Lua📈 view plot
🚷 view threshold
3,076.20 ns
(-27.78%)Baseline: 4,259.77 ns
5,521.83 ns
(55.71%)
resource/access Rhai📈 view plot
🚷 view threshold
5,569.90 ns
(-7.45%)Baseline: 6,018.41 ns
7,377.97 ns
(75.49%)
resource/get Lua📈 view plot
🚷 view threshold
1,735.00 ns
(-26.90%)Baseline: 2,373.45 ns
3,015.25 ns
(57.54%)
resource/get Rhai📈 view plot
🚷 view threshold
4,339.30 ns
(+1.18%)Baseline: 4,288.84 ns
5,294.15 ns
(81.96%)
🐰 View full continuous benchmarking report in Bencher

@makspll makspll merged commit cabb723 into main Apr 7, 2025
19 checks passed
@makspll makspll deleted the fix/lua54-forced branch April 7, 2025 17:30
@github-actions github-actions bot mentioned this pull request Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant