Deprecate HanaDB, HanaTranslator and update example notebook to use new implementation #30896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or implementations - Add deprecation warnings to hana implementation that are in langchain-hana.
…implementation - Replaced usage of the deprecated HanaDB class with the new HanaDB from the langchain_hana package. - Updated import paths and example code to reflect the recommended migration path. - Added examples demonstrating new features such as keyword search and internal embeddings.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:L
|
Hi @ccurme @baskaryan @efriis @eyurtsev 👋 could you please take a look at this PR and let us know if anything is missing? I'd appreciate your feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR marks the
HanaDBvector store (and related utilities) inlangchain_communityas deprecated using the@deprecatedannotation.since="0.1.0"andremoval="1.0"langchain_hanapackage.Additionally, the example notebook has been updated to use the new
HanaDBclass fromlangchain_hana, ensuring users follow the recommended integration moving forward.Issue: None
Dependencies: None