Skip to content

Barebox/UBoot/SmallUBootDriver: handle hex arguements properly #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pmelange
Copy link
Contributor

Checks to see if the interrupt string starts with \x and when that is the case, converts the remained of the string to a bytearray before sending the interrupt to the boot loader.

fixes #1622

@pmelange pmelange force-pushed the bootload_driver_handle_hex branch from 2abc1d5 to 47a26dc Compare February 28, 2025 10:47
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 55.7%. Comparing base (2ce9e24) to head (315a968).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
labgrid/driver/smallubootdriver.py 0.0% 8 Missing ⚠️
labgrid/driver/bareboxdriver.py 0.0% 7 Missing ⚠️
labgrid/driver/ubootdriver.py 0.0% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1623     +/-   ##
========================================
- Coverage    55.8%   55.7%   -0.1%     
========================================
  Files         170     170             
  Lines       13382   13400     +18     
========================================
  Hits         7469    7469             
- Misses       5913    5931     +18     
Flag Coverage Δ
3.10 55.7% <0.0%> (-0.1%) ⬇️
3.11 55.7% <0.0%> (-0.1%) ⬇️
3.12 55.7% <0.0%> (-0.1%) ⬇️
3.13 55.7% <0.0%> (-0.1%) ⬇️
3.9 55.7% <0.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Checks to see if the interrupt string starts with \x and when that
is the case, converts the remained of the string to a bytearray before
sending the interrupt to the boot loader.

fixes labgrid-project#1622

Signed-off-by: Perry Melange <isprotejesvalkata@gmail.com>
@pmelange pmelange force-pushed the bootload_driver_handle_hex branch from 47a26dc to 315a968 Compare March 1, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BareboxDriver and (Small)UBootDriver: does not handle hex interrupt arguments (such as Ctrl-C) properly
1 participant