Skip to content

extract pod representation from backend/metrics to backend #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

nirrozenbaum
Copy link
Contributor

This PR extracts the Pod minimal representation from backend/metrics to backend.
I'm working on other PRs that implement scraper concept to allow extensibility for pod scraping.
for the use of this, it's useful to reuse the same pod definition.

since this change touches a lot of files that are using the pod definition, it makes sense to push it in a separate PR.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 28, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 28, 2025
Copy link

netlify bot commented Apr 28, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit ea9e047
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/68107e87a854af00080ffce7
😎 Deploy Preview https://deploy-preview-751--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nirrozenbaum
Copy link
Contributor Author

nirrozenbaum commented Apr 28, 2025

CC @kfswain @ahg-g

@kfswain
Copy link
Collaborator

kfswain commented Apr 29, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kfswain, nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 29, 2025
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 29, 2025
@kfswain
Copy link
Collaborator

kfswain commented Apr 29, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2025
@k8s-ci-robot k8s-ci-robot merged commit 28c7484 into kubernetes-sigs:main Apr 29, 2025
8 checks passed
@nirrozenbaum nirrozenbaum deleted the extract-pod-def branch April 29, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants