Skip to content

feat: Initial setup for conformance test suite #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Apr 29, 2025
Merged

feat: Initial setup for conformance test suite #720

merged 17 commits into from
Apr 29, 2025
+671 −31

Conversation

SinaChavoshi
Copy link
Contributor

Adding the basic directory structure, core suite files, base manifests, and a placeholder test for InferencePool acceptance, leveraging upstream gateway-api utilities.

This is per design discussed in Conformance Test Technical Design for Gateway API Inference Extension

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Apr 21, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 21, 2025
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 21, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @SinaChavoshi!

It looks like this is your first PR to kubernetes-sigs/gateway-api-inference-extension 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api-inference-extension has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @SinaChavoshi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@netlify Netlify
Copy link

netlify bot commented Apr 21, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit b63ef3a
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/680fe4c8a137a60008120583
😎 Deploy Preview https://deploy-preview-720--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 21, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 22, 2025
@kfswain
Copy link
Collaborator

kfswain commented Apr 22, 2025

This effort is part of #500

@robscott
Copy link
Member

Thanks @SinaChavoshi!

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 22, 2025
@SinaChavoshi
Copy link
Contributor Author

/retest

@SinaChavoshi
Copy link
Contributor Author

/retest

robscott
robscott reviewed Apr 23, 2025
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SinaChavoshi! This is a great start!

danehans
danehans requested changes Apr 24, 2025
View reviewed changes
@SinaChavoshi SinaChavoshi requested a review from danehans April 25, 2025 22:05
robscott
robscott reviewed Apr 26, 2025
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SinaChavoshi! This mostly LGTM, just a few tiny nits.

@SinaChavoshi SinaChavoshi mentioned this pull request Apr 28, 2025
Open
@SinaChavoshi SinaChavoshi requested a review from robscott April 28, 2025 23:32
danehans
danehans approved these changes Apr 29, 2025
View reviewed changes
conformance/conformance.go
// In future iterations, we will add constants and ConformanceProfile structs for
// EPPProfileName ("EPP") and ModelServerProfileName ("ModelServer")
// to cover their respective conformance layers.
var GatewayLayerProfile = confsuite.ConformanceProfile{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The term "layer" leads me to believe conformance dependencies exist between EPP, Gateway, etc. @robscott does Gateway API have a naming standard for different profiles? IMO, using "component" indicates independence among the profiles.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans, SinaChavoshi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2025
@danehans
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2025
@k8s-ci-robot k8s-ci-robot merged commit ef3d01a into kubernetes-sigs:main Apr 29, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danehans danehans danehans approved these changes

@liu-cong liu-cong Awaiting requested review from liu-cong

@ahg-g ahg-g Awaiting requested review from ahg-g

@kfswain kfswain Awaiting requested review from kfswain

@robscott robscott Awaiting requested review from robscott

Assignees

@danehans danehans

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SinaChavoshi @k8s-ci-robot @kfswain @robscott @danehans