Skip to content

feat(hosttailer): reduce fluent-bit log level to error #1957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

aslafy-z
Copy link
Collaborator

@aslafy-z aslafy-z commented Feb 27, 2025

@aslafy-z aslafy-z changed the title feat(hosttailer): reduce fluent-bit log level to error feat(tailer): reduce fluent-bit log level to error Feb 27, 2025
@csatib02 csatib02 requested a review from pepov February 27, 2025 19:06
@csatib02 csatib02 added the enhancement New feature or request label Mar 24, 2025
@aslafy-z aslafy-z force-pushed the aslafy-z-patch-2 branch 2 times, most recently from a2b62e0 to a1edd03 Compare April 11, 2025 16:00
@aslafy-z aslafy-z requested review from pepov and csatib02 April 11, 2025 16:00
@aslafy-z aslafy-z changed the title feat(tailer): reduce fluent-bit log level to error feat(hosttailer): reduce fluent-bit log level to error Apr 11, 2025
Copy link
Member

@csatib02 csatib02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@csatib02 csatib02 requested review from pepov and removed request for pepov April 11, 2025 19:31
Signed-off-by: Zadkiel AHARONIAN <hello@zadkiel.fr>
@pepov pepov force-pushed the aslafy-z-patch-2 branch from 57e5eb2 to b98a7a6 Compare April 24, 2025 19:31
@csatib02 csatib02 merged commit 7e1f9aa into master Apr 24, 2025
33 checks passed
@csatib02 csatib02 deleted the aslafy-z-patch-2 branch April 24, 2025 20:29
@pepov pepov changed the title feat(hosttailer): reduce fluent-bit log level to error feat(hosttailer): silence fluent-bit log Apr 25, 2025
@pepov pepov changed the title feat(hosttailer): silence fluent-bit log feat(hosttailer): reduce fluent-bit log level to error Apr 25, 2025
@pepov
Copy link
Member

pepov commented Apr 25, 2025

I came back here after the fact to double check what -qq does as I realized I haven't heard about that. I'm not sure where it was coming from, the only reference I found is from an internal lib in fluentbit that allows passing this argument multiple times, but fluentbit itself does not seem to behave differently with or without a second q:

docker run --rm fluent/fluent-bit:3.2.5 -o asdf -q
[2025/04/25 06:25:42] [error] [config] section 'asdf' tried to instance a plugin name that doesn't exist
[2025/04/25 06:25:42] [error] configuration file contains errors, aborting.
docker run --rm fluent/fluent-bit:3.2.5 -o asdf -qq
[2025/04/25 06:25:40] [error] [config] section 'asdf' tried to instance a plugin name that doesn't exist
[2025/04/25 06:25:40] [error] configuration file contains errors, aborting.

Overall -qq seems to behave the same and the original PR title is correct. No action needed from my side, just wanted to note here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants