Skip to content

Add kokkos tests to CI #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
235 changes: 82 additions & 153 deletions .github/workflows/cmake.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,165 +3,94 @@ name: CMake
on: [push, pull_request]

env:
# Customize the CMake build type here (Release, Debug, RelWithDebInfo, etc.)
BUILD_TYPE: RelWithDebInfo
CXX: g++-10 # Note: need GCC v10 (or newer) to avoid TBB compilation errors
CC: gcc-10 # Note: g++-11 fails with "sorry, unimplemented: unexpected AST of kind nontype_argument_pack"
CXX_STANDARD: 17
KOKKOS_VERSION: 3.6.00 # develop
KK_VERSION: 3.6.00 # develop
SHARED_LIBS: ON

jobs:
build-mdspan:
stdblas:
name: Test stdBLAS
runs-on: ubuntu-latest
container:
image: amklinv/stdblas:latest
defaults:
run:
shell: bash

steps:
strategy:
matrix:
implementation: [Native, Kokkos]
cmake_build_type: [Release, Debug] # RelWithDebInfo

env:
BUILD_TYPE: ${{ matrix.cmake_build_type }}
INSTALL_PATH: ${{ github.workspace }}/install
UTILS_PATH: ${{ github.workspace }}/src/stdblas/.github/workflows/utils
KOKKOS_BACKEND: Serial # TODO: ${{ matrix.kokkos_backend }} ?
# FIXME OpenMP fails tests with: "Kokkos::OpenMP parallel_reduce ERROR: in parallel or not initialized"
# FIXME Threads fails tests with: "ThreadsExec::start FAILED : Threads not initialized."

- id: get-sha
run: echo ::set-output name=sha::$( curl https://api.github.com/repos/kokkos/mdspan/git/ref/heads/stable | jq .object.sha | tr -d '"' )

- name: Determine whether mdspan needs to be rebuilt
id: cache-mdspan
uses: actions/cache@v2
with:
path: mdspan-install
key: mdspan-${{ steps.get-sha.outputs.sha }}

- name: Create Build Environment
if: steps.cache-mdspan.outputs.cache-hit != 'true'
run: cmake -E make_directory mdspan-build

- name: Check Out
if: steps.cache-mdspan.outputs.cache-hit != 'true'
uses: actions/checkout@v2
with:
repository: kokkos/mdspan
path: mdspan-src

- name: Configure CMake
if: steps.cache-mdspan.outputs.cache-hit != 'true'
working-directory: mdspan-build
run: cmake $GITHUB_WORKSPACE/mdspan-src -DCMAKE_BUILD_TYPE=$BUILD_TYPE -DCMAKE_INSTALL_PREFIX=$GITHUB_WORKSPACE/mdspan-install

- name: Build
if: steps.cache-mdspan.outputs.cache-hit != 'true'
working-directory: mdspan-build
run: make

- name: Install
if: steps.cache-mdspan.outputs.cache-hit != 'true'
working-directory: mdspan-build
run: make install

- name: Upload
uses: actions/upload-artifact@v2
with:
name: mdspan
path: mdspan-install

configure-stdblas:
runs-on: ubuntu-latest
container:
image: amklinv/mdspan-dependencies:latest
needs: build-mdspan

steps:
- name: Download mdspan
uses: actions/download-artifact@v2
with:
name: mdspan
path: mdspan-install

- name: Create Build Environment
run: cmake -E make_directory stdblas-build

- name: Check Out
uses: actions/checkout@v2
with:
path: stdblas-src

- name: Configure CMake
shell: bash
working-directory: stdblas-build
run: cmake $GITHUB_WORKSPACE/stdblas-src -Dmdspan_DIR=$GITHUB_WORKSPACE/mdspan-install/lib/cmake/mdspan -DLINALG_ENABLE_TESTS=On -DLINALG_ENABLE_EXAMPLES=On -DCMAKE_BUILD_TYPE=$BUILD_TYPE -DCMAKE_INSTALL_PREFIX=$GITHUB_WORKSPACE/stdblas-install

- name: Upload workspace
uses: actions/upload-artifact@v2
with:
name: workspace
path: .

build-stdblas:
runs-on: ubuntu-latest
container:
image: amklinv/mdspan-dependencies:latest
needs: configure-stdblas

steps:

- name: Download workspace
uses: actions/download-artifact@v2
with:
name: workspace
path: .

- name: Build
working-directory: stdblas-build
shell: bash
run: make

- name: Tar files
shell: bash
run: tar -cvf stdblas.tar *

- name: Upload workspace
uses: actions/upload-artifact@v2
with:
name: stdblas
path: stdblas.tar

test-stdBLAS:
runs-on: ubuntu-latest
container:
image: amklinv/mdspan-dependencies:latest
needs: build-stdblas

steps:

- name: Download workspace
uses: actions/download-artifact@v2
with:
name: stdblas
path: .

- name: Untar files
shell: bash
run: tar -xvf stdblas.tar

- name: Test
working-directory: stdblas-build
shell: bash
run: ctest --output-on-failure

install-stdBLAS:
runs-on: ubuntu-latest
container:
image: amklinv/mdspan-dependencies:latest
needs: build-stdblas

steps:

- name: Download workspace
uses: actions/download-artifact@v2
with:
name: stdblas
path: .

- name: Untar files
shell: bash
run: tar -xvf stdblas.tar

- name: Install
working-directory: stdblas-build
shell: bash
run: make install

- name: Check out stdBLAS
uses: actions/checkout@v2
with:
path: src/stdblas

- name: Check out mdspan
uses: actions/checkout@v2
with:
repository: kokkos/mdspan
path: src/mdspan

- name: Build and install mdspan
run: $UTILS_PATH/build_mdspan.sh

- name: Check out Kokkos
if: matrix.implementation == 'Kokkos'
uses: actions/checkout@v2
with:
repository: kokkos/kokkos
path: src/kokkos
ref: ${{ env.KOKKOS_VERSION }}

- name: Build and install Kokkos
if: matrix.implementation == 'Kokkos'
run: $UTILS_PATH/build_kokkos.sh

- name: Check out Kokkos-Kernels
if: matrix.implementation == 'Kokkos'
uses: actions/checkout@v2
with:
repository: kokkos/kokkos-kernels
path: src/kokkos-kernels
ref: ${{ env.KK_VERSION }}

- name: Build and install Kokkos-Kernels
if: matrix.implementation == 'Kokkos'
run: $UTILS_PATH/build_kokkos-kernels.sh

- name: Configure stdBLAS
run: |
[[ ${{ matrix.implementation }} == "Kokkos" ]] && ENABLE_KOKKOS=ON
cmake \
-S $GITHUB_WORKSPACE/src/stdblas \
-B $GITHUB_WORKSPACE/build/stdblas \
-DCMAKE_BUILD_TYPE:STRING=${{ matrix.cmake_build_type }} \
-DCMAKE_INSTALL_PREFIX:FILEPATH=$GITHUB_WORKSPACE/install \
-DBUILD_SHARED_LIBS=$SHARED_LIBS \
-DCMAKE_CXX_STANDARD:STRING=$CXX_STANDARD \
-DLINALG_ENABLE_TESTS:BOOL=ON \
-DLINALG_ENABLE_EXAMPLES:BOOL=On \
-DLINALG_ENABLE_CONCEPTS:BOOL=ON \
-DLINALG_ENABLE_KOKKOS:BOOL=$ENABLE_KOKKOS \
-DLINALG_ENABLE_KOKKOS_DEFAULT:BOOL=$ENABLE_KOKKOS

- name: Build stdBLAS
run: |
cmake --build $GITHUB_WORKSPACE/build/stdblas -j $(nproc)

- name: Test stdBLAS
working-directory: build/stdblas
run: ctest -j $(nproc) --timeout 60 --output-on-failure
38 changes: 38 additions & 0 deletions .github/workflows/utils/build_kokkos-kernels.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
#!/usr/bin/bash

SRC_PATH=$GITHUB_WORKSPACE/src/kokkos-kernels
BUILD_PATH=$GITHUB_WORKSPACE/build/kokkos-kernels

ENABLE_KK_ETI=OFF

# Configure Kokkos-Kernels
cmake \
-S $SRC_PATH \
-B $BUILD_PATH \
-DCMAKE_BUILD_TYPE:STRING=$BUILD_TYPE \
-DCMAKE_INSTALL_PREFIX:FILEPATH=$INSTALL_PATH \
-DBUILD_SHARED_LIBS=$SHARED_LIBS \
-DKokkosKernels_ENABLE_TESTS:BOOL=OFF \
-DKokkosKernels_ENABLE_DOCS:BOOL=OFF \
-DKokkosKernels_ENABLE_TESTS_AND_PERFSUITE:BOOL=OFF \
-DKokkosKernels_ENABLE_EXPERIMENTAL:BOOL=ON \
-DKokkosKernels_INST_DOUBLE:BOOL=$ENABLE_KK_ETI \
-DKokkosKernels_INST_FLOAT:BOOL=OFF \
-DKokkosKernels_INST_COMPLEX_FLOAT:BOOL=OFF \
-DKokkosKernels_INST_COMPLEX_DOUBLE:BOOL=OFF \
-DKokkosKernels_INST_ORDINAL_INT:BOOL=$ENABLE_KK_ETI \
-DKokkosKernels_INST_ORDINAL_INT64_T:BOOL=OFF \
-DKokkosKernels_INST_OFFSET_INT:BOOL=$ENABLE_KK_ETI \
-DKokkosKernels_INST_OFFSET_SIZE_T:BOOL=OFF \
-DKokkosKernels_INST_LAYOUTLEFT:BOOL=$ENABLE_KK_ETI \
-DKokkosKernels_INST_LAYOUTRIGHT:BOOL=OFF
[[ $? -ne 0 ]] && exit 1


# Build Kokkos-Kernels
cmake --build $GITHUB_WORKSPACE/build/kokkos-kernels -j $(nproc)

[[ $? -ne 0 ]] && exit 1

# Install Kokkos-Kernels
cmake --install $GITHUB_WORKSPACE/build/kokkos-kernels
40 changes: 40 additions & 0 deletions .github/workflows/utils/build_kokkos.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
#!/usr/bin/bash

SRC_PATH=$GITHUB_WORKSPACE/src/kokkos
BUILD_PATH=$GITHUB_WORKSPACE/build/kokkos

# Note: enabling parallel backend, like OpenMP
# gives a chance to detect threading issues, e.g. races
ENABLE_SERIAL=OFF
[ $KOKKOS_BACKEND == 'Serial' ] && ENABLE_SERIAL=ON
ENABLE_OPENMP=OFF
[ $KOKKOS_BACKEND == 'OpenMP' ] && ENABLE_OPENMP=ON
ENABLE_THREADS=OFF
[ $KOKKOS_BACKEND == 'Threads' ] && ENABLE_THREADS=ON

# Configure Kokkos
cmake \
-S $SRC_PATH \
-B $BUILD_PATH \
-DCMAKE_BUILD_TYPE:STRING=$BUILD_TYPE \
-DCMAKE_INSTALL_PREFIX:FILEPATH=$INSTALL_PATH \
-DBUILD_SHARED_LIBS=$SHARED_LIBS \
-DCMAKE_CXX_FLAGS:STRING=-Werror \
-DKokkos_CXX_STANDARD:STRING=$CXX_STANDARD \
-DKokkos_ENABLE_COMPLEX_ALIGN:BOOL=OFF \
-DKokkos_ENABLE_COMPILER_WARNINGS:BOOL=ON \
-DKokkos_ENABLE_DEPRECATED_CODE_3:BOOL=OFF \
-DKokkos_ENABLE_TESTS:BOOL=OFF \
-DKokkos_ENABLE_SERIAL:BOOL=$ENABLE_SERIAL \
-DKokkos_ENABLE_OPENMP:BOOL=$ENABLE_OPENMP \
-DKokkos_ENABLE_THREADS:BOOL=$ENABLE_THREADS

[[ $? -ne 0 ]] && exit 2

# Build mdspan
cmake --build $BUILD_PATH -j $(nproc)

[[ $? -ne 0 ]] && exit 1

# Install mdspan
cmake --install $BUILD_PATH
22 changes: 22 additions & 0 deletions .github/workflows/utils/build_mdspan.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
#!/usr/bin/bash

SRC_PATH=$GITHUB_WORKSPACE/src/mdspan
BUILD_PATH=$GITHUB_WORKSPACE/build/mdspan

# Configure mdspan
cmake \
-S $SRC_PATH \
-B $BUILD_PATH \
-DCMAKE_BUILD_TYPE:STRING=$BUILD_TYPE \
-DCMAKE_INSTALL_PREFIX:FILEPATH=$INSTALL_PATH \
-DBUILD_SHARED_LIBS=$SHARED_LIBS

[[ $? -ne 0 ]] && exit 1

# Build mdspan
cmake --build $BUILD_PATH -j $(nproc)

[[ $? -ne 0 ]] && exit 1

# Install mdspan
cmake --install $BUILD_PATH