Don't shell out to the same binary #258
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calling `auroraboot` from within the `auroraboot` go binary is weird and makes development harder (since a simple `go run .` doesn't cut it, you also need to build the `auroraboot` binary and put it in the PATH). We probalby did it because of the packages not being very well structured, easily leading to circular imports. Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #258 +/- ##
=======================================
Coverage 28.52% 28.52%
=======================================
Files 20 20
Lines 2780 2780
=======================================
Hits 793 793
Misses 1862 1862
Partials 125 125 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
calling
aurorabootfrom within theaurorabootgo binary is weird and makes development harder (since a simplego run .doesn't cut it, you also need to build theaurorabootbinary and put it in the PATH). We probalby did it because of the packages not being very well structured, easily leading to circular imports.