Support generator return values in QuickJSIterator #221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the quickjs iterator does not support generator function return values, as it assumes when
done === true
thenvalue === undefined
.This is not the case for generator-derived iterators
MDN docs are a little vague on this so I can understand the confusion
However - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/function*#description:
I guess the key word is "can" be omitted, not "must"