-
Notifications
You must be signed in to change notification settings - Fork 96
TUI rewrite #1255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dfordivam
wants to merge
43
commits into
master
Choose a base branch
from
dn-tui-rewrite-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
TUI rewrite #1255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the apis to BrickMain
lsmor
reviewed
Apr 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not able to fully review this as the code is way more complex than my knowledge 😅 . My understading is:
- Menus are defined by two parallel datatypes The "Fields" + "Options", and then this
GenericMenu
thing which I barely understand... Instead of Having "Options" + list of fields as before. - Existentials are hidden behind TypeClasses + Data.Some if I understand correctly.
- I don't get the Overlays part. AFAIU,
brick
dispatches events to the frontward layers, so there is no need to pass events to the "child"/overlayed widget... but maybe I got this wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes use of existentials. fixes Remove existential types in TUI #1217
Makes use of GHC.Generics to take care of the Menu boilerplate
Improves the structure of code as each widget now need to implement the instance of BaseWidget, which captures the two essential parts, rendering and event handling.
The structure of the widget state matches directly to the "tree" structure of widgets. And the use of enums, like
Mode
, have been removed.The input fields are more generic and we can nest them, like
EditInput
is being used insideSelectInput
The value of input fields can be modified like this
The child widget does not modify the state of parent (as it was earlier being done via lens)
The 'quit' key handling logic is now mostly part of the
BasicOverlay
abstraction, and has been removed from the event handlers of individual widgets.We can even do nesting of
GenericMenu
, in case we want to make fancy sub-menus