-
Notifications
You must be signed in to change notification settings - Fork 48
fix(components): LinkToExternal
#2832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
a27b1fe
to
1ef54f7
Compare
1ef54f7
to
d0b8990
Compare
d0b8990
to
2684433
Compare
fix(components): `LinkToExtrnal`
2684433
to
5f7693a
Compare
bf0594d
to
ac6637d
Compare
9d834d8
to
32a9f43
Compare
32a9f43
to
4d30d94
Compare
4d30d94
to
3f1be72
Compare
3f1be72
to
8bab8ed
Compare
📦 RC Packages PublishedLatest commit: 8bab8ed Published 1 packages@hashicorp/design-system-components@4.19.0-rc-20250422072018
|
superseded by #2838 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
Today we are referencing
<LinkToExternal/>
component and in the many cases it doesn't exists unless consumer hasember-engines
as dependancy. In theembroider/vite
world all components are evaluated at the build time and needs to resolve correct dependancy. If we were to runhds
embroider/vite today it would result in an error about unresolvedLinkToExternal
component. In order to make this behaviour more controlled we are encapsulating requirements forember-engines
to be explicitly required only in situation when we pass@isRouteExternal
astrue
in which case we do our check for required dependancy resigne component instance or through an error.Shipping
ember-engines
is not an option for a couple of reasons:🛠️ Detailed description
📸 Screenshots
🔗 External links
Jira ticket: HDS-XXX
Figma file: [if it applies]
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.