Skip to content

Davidmotson.firebase ai #6911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Davidmotson.firebase ai #6911

wants to merge 12 commits into from

Conversation

davidmotson
Copy link
Collaborator

No description provided.

David Motsonashvili and others added 3 commits April 23, 2025 11:59
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v10.0

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@davidmotson davidmotson requested a review from rlazo April 25, 2025 18:57
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 25, 2025

Size Report 1

Affected Products

  • firebase-ai

    TypeBase (12127e6)Merge (7eb73f3)Diff
    aar?801 kB? (?)
    apk (aggressive)?1.54 MB? (?)
    apk (release)?9.51 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/HSgSWylIUk.html

@davidmotson davidmotson enabled auto-merge (squash) April 25, 2025 19:04
Copy link
Contributor

github-actions bot commented Apr 25, 2025

Test Results

 1 034 files  + 1 016   1 034 suites  +1 016   34m 52s ⏱️ + 34m 38s
 5 874 tests + 5 788   5 852 ✅ + 5 766  22 💤 +22  0 ❌ ±0 
11 811 runs  +11 639  11 767 ✅ +11 595  44 💤 +44  0 ❌ ±0 

Results for commit 197b090. ± Comparison against base commit 12127e6.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 25, 2025

Coverage Report 1

This report is too large (69,876 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/lJyPVE17ts.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 25, 2025

Startup Time Report 1

The report is too large (122,596 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/FXHn04siXf/index.html

Copy link
Member

@daymxn daymxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Left some comments, but otherwise LGTM. I defer to @rlazo for final approval tho.

if (it.metadata?.get("service") == "firebasevertexai.googleapis.com") {
"""
The Firebase AI SDK requires the Vertex AI in Firebase API
(`firebasevertexai.googleapis.com`) to be enabled in your Firebase project. Enable this API
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still the name of the service?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great question!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error only pops up if the service is firebasevertexai.googleapis.com, so I think this error should be good

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point. But is there another firebaseai adjacent service that we should be throwing a similar message for?

davidmotson and others added 5 commits April 25, 2025 14:07
Co-authored-by: Daymon <17409137+daymxn@users.noreply.github.com>
Co-authored-by: Daymon <17409137+daymxn@users.noreply.github.com>
…ultiResourceComponent.kt

Co-authored-by: Daymon <17409137+daymxn@users.noreply.github.com>
Co-authored-by: Daymon <17409137+daymxn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants