-
Notifications
You must be signed in to change notification settings - Fork 604
Davidmotson.firebase ai #6911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Davidmotson.firebase ai #6911
Conversation
…ort (#6907) Co-authored-by: David Motsonashvili <davidmotson@google.com>
Vertex AI Mock Responses Check
|
Generated by 🚫 Danger |
Size Report 1Affected Products
Test Logs |
Test Results 1 034 files + 1 016 1 034 suites +1 016 34m 52s ⏱️ + 34m 38s Results for commit 197b090. ± Comparison against base commit 12127e6. ♻️ This comment has been updated with latest results. |
Coverage Report 1This report is too large (69,876 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Left some comments, but otherwise LGTM. I defer to @rlazo for final approval tho.
firebase-ai/src/main/kotlin/com/google/firebase/ai/FirebaseAIMultiResourceComponent.kt
Outdated
Show resolved
Hide resolved
if (it.metadata?.get("service") == "firebasevertexai.googleapis.com") { | ||
""" | ||
The Firebase AI SDK requires the Vertex AI in Firebase API | ||
(`firebasevertexai.googleapis.com`) to be enabled in your Firebase project. Enable this API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still the name of the service?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great question!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This error only pops up if the service is firebasevertexai.googleapis.com, so I think this error should be good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point. But is there another firebaseai
adjacent service that we should be throwing a similar message for?
firebase-ai/src/main/kotlin/com/google/firebase/ai/FirebaseAI.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Daymon <17409137+daymxn@users.noreply.github.com>
Co-authored-by: Daymon <17409137+daymxn@users.noreply.github.com>
…ultiResourceComponent.kt Co-authored-by: Daymon <17409137+daymxn@users.noreply.github.com>
Co-authored-by: Daymon <17409137+daymxn@users.noreply.github.com>
No description provided.