-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Inspector support for vite #20892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Inspector support for vite #20892
Conversation
Development AssetsDiff --- main/out.txt 2025-04-10 17:47:56.000000000 +0000
+++ pr/./pr-14389466056/out.txt 2025-04-10 20:16:14.000000000 +0000
@@ -1,5 +1,5 @@
2.2M └─┬ .
-1015K ├─┬ @ember
+1016K ├─┬ @ember
205K │ ├─┬ -internals
69K │ │ ├─┬ views
64K │ │ │ └─┬ lib
@@ -37,7 +37,7 @@
4.1K │ │ └── -internal
66K │ ├─┬ application
5.6K │ │ └── lib
- 52K │ ├─┬ debug
+ 53K │ ├─┬ debug
21K │ │ └── lib
38K │ ├─┬ array
4.9K │ │ └── lib Details
|
76fc03a
to
d019b39
Compare
// eslint-disable-next-line no-var, @typescript-eslint/no-unused-vars | ||
var emberInspectorLoader: any; | ||
|
||
globalThis.emberInspectorLoader = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const SECRET = Symbol.for('__ember-inspector_loader_please_🙏_dont_import_this_its_not_public_api_thank_you_❤️__');
globalThis[SECRET] = {
// ...
ObjectPromiseProxyMixin: await import('@ember/object/promise-proxy-mixin'), | ||
ObjectProxy: await import('@ember/object/proxy'), | ||
Service: await import('@ember/service'), | ||
VERSION: await import('ember/version'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can VERSION be outside the load function? it's like 3 bytes and would allow the inspector to branch functionality before loading (via load()
all these modules)
No description provided.