Ability to hide pinned messages (#28183) #29604
Conversation
|
|
github-actions
bot
added
the
Z-Community-PR
marekjm
force-pushed
the
marekjm/ability-to-hide-pinned-messages
branch
from
d17604a to
150de3d
Compare
| @@ -345,6 +346,22 @@ export default function RoomHeader({ | |||
|
|
|||
| {showChatButton && <VideoRoomChatButton room={room} />} | |||
|
|
|||
| <Tooltip label={_t("right_panel|pinned_messages_button")}> | |||
| <IconButton | |||
| indicator={notificationLevelToIndicator(threadNotifications)} | |||
There was a problem hiding this comment.
The indicator here is obviously incorrect. I would appreciate some help on what exactly should be used here.
| onClick={(evt) => { | ||
| evt.stopPropagation(); | ||
| RightPanelStore.instance.showOrHidePhase(RightPanelPhases.PinnedMessages); | ||
| // FIXME Track interaction with PinnedMessages |
There was a problem hiding this comment.
This FIXME is another point on which I would appreciate some guidance. Is this tracking needed?
marekjm
force-pushed
the
marekjm/ability-to-hide-pinned-messages
branch
from
150de3d to
15e4470
Compare
|
Hi, thanks for contribution! Before doing the review, we will wait for product point of view on the feature |
|
No problem. I will give my €0.02 for any deliberations. In a pre-patch discussion I had, an idea was floated that the pins were supposed to always stay on top of the room to inform members of important messages eg, rules or some such (I do not actually know if that was really the idea behind pins), but this is already better addressed using room topic I would say. If necessary, the topic may include "See pinned messages" to direct people to further information--which can now be easily accessed using the pin icon in room header. |
marekjm
force-pushed
the
marekjm/ability-to-hide-pinned-messages
branch
2 times, most recently
from
31623bd to
c75e5b2
Compare
jitsi.md was linked both here and in the 'setup' section and I think it's more relevant to setup. The duplicate links are now breaking the deploy for some reason. We probably shouldn't have both.
Currently, when a room has pinned messages an annoying, impossible to dismiss bar will be displayed over the message area. This patch introduces the following changes: - add a setting to control whether the PinnedMessageBanner is displayed or not (keep current behaviour as default) - add a pin icon to the room header Why allow hiding pinned messages? Because the banner is annoying. I, and judging by the +1s on element-hq#28183 a few other users, found it unnecessary to always have it in front of our eyes. The new setting allows us to make it go away. Why add an icon for pinned messages if you can view pinned messages from room info? I will answer this by posing another question: why display the banner when pinned messages can be viewed from room info? Jokes aside, the icon makes the access quicker--the UX is exactly the same as for threads: you can see then from room info, or by clicking their icon. Fixes element-hq#28183
marekjm
force-pushed
the
marekjm/ability-to-hide-pinned-messages
branch
from
c75e5b2 to
f6459d0
Compare
Currently, when a room has pinned messages an annoying, impossible to dismiss bar will be displayed over the message area. This patch introduces the following changes:
Why allow hiding pinned messages? Because the banner is annoying. I, and judging by the +1s on #28183 a few other users, found it unnecessary to always have it in front of our eyes. The new setting allows us to make it go away.
Why add an icon for pinned messages if you can view pinned messages from room info? I will answer this by posing another question: why display the banner when pinned messages can be viewed from room info? Jokes aside, the icon makes the access quicker--the UX is exactly the same as for threads: you can see then from room info, or by clicking their icon.
Fixes #28183
Checklist
public/exportedsymbols have accurate TSDoc documentation.