[Test Only] Fix Idn tests #115032
Merged
[Test Only] Fix Idn tests #115032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes IDN tests by incorporating updated Unicode 16.0 test data and adjusting ICU version checks accordingly.
- Introduces a new test class for Unicode 16.0 IDNA mapping.
- Updates ICU version conditions in the factory and test result classes.
- Adds documentation for the new Unicode 16.0 test data.
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Unicode_16_0_IdnaTest.cs | New test implementation for Unicode 16.0 data |
| ReadMe.txt | Documentation updated with Unicode 16.0 details |
| Factory.cs | Revised ICU version checks to reference Unicode 16.0 data |
| ConformanceIdnaUnicodeTestResult.cs | Adds a new constructor overload for handling source data |
| ConformanceIdnaTestResult.cs | Introduces a new source parameter and enhances validation via IsIgnorableA4_2Rule |
Files not reviewed (2)
- src/libraries/System.Runtime/tests/System.Globalization.Extensions.Tests/NlsTests/System.Globalization.Extensions.Nls.Tests.csproj: Language not supported
- src/libraries/System.Runtime/tests/System.Globalization.Extensions.Tests/System.Globalization.Extensions.Tests.csproj: Language not supported
|
Tagging subscribers to this area: @dotnet/area-system-globalization |
carlossanlop
added
Servicing-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.