Slightly improve performance and maintainability in SequentialGuidValueGenerator #35981
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace unnecessary byte copying with direct in-place modification.
Guid uses a sequential layout where the first 8 bytes require endianness handling on big-endian systems when reading from or writing to a byte array (e.g., via
MemoryMarshal
orGuid
constructors). The remaining 8 bytes are interpreted as-is, regardless of endianness.Since we only modify the last 8 bytes of the
Guid
, byte order does not affect the result, so we can:MemoryMarshal.AsBytes
for direct accessThe optimization maintains identical behavior while being more efficient.