Skip to content

chore(ci): Remove obsolete cloud workflow (in favor of extending push wf) #9491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(ci): Remove obsolete cloud workflow (in favor of extending push wf) #9491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/actions/integration/athena.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ set -eo pipefail
export DEBUG=testcontainers

echo "::group::Athena [cloud]"
export CUBEJS_AWS_KEY=$DRIVERS_TESTS_SNOWFLAKE_CUBEJS_AWS_KEY
export CUBEJS_AWS_SECRET=$DRIVERS_TESTS_SNOWFLAKE_CUBEJS_AWS_SECRET

export CUBEJS_AWS_REGION=us-east-1
export CUBEJS_AWS_S3_OUTPUT_LOCATION=s3://cubejs-opensource/testing/output
export CUBEJS_DB_EXPORT_BUCKET=s3://cubejs-opensource/testing/export/
Expand Down
1 change: 1 addition & 0 deletions .github/actions/integration/bigquery.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ set -eo pipefail
export DEBUG=testcontainers

echo "::group::BigQuery [cloud]"
export CUBEJS_DB_BQ_CREDENTIALS=$DRIVERS_TESTS_SNOWFLAKE_CUBEJS_DB_BQ_CREDENTIALS
export CUBEJS_DB_BQ_PROJECT_ID=cube-open-source
export CUBEJS_DB_EXPORT_BUCKET=cube-open-source-export-bucket
yarn lerna run --concurrency 1 --stream --no-prefix integration:bigquery
Expand Down
2 changes: 2 additions & 0 deletions .github/actions/integration/snowflake.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ export CUBEJS_DB_NAME=DEMO_DB
export CUBEJS_DB_SNOWFLAKE_ACCOUNT=lxb31104
export CUBEJS_DB_SNOWFLAKE_REGION=us-west-2
export CUBEJS_DB_SNOWFLAKE_WAREHOUSE=COMPUTE_WH
export CUBEJS_DB_USER=$DRIVERS_TESTS_SNOWFLAKE_CUBEJS_DB_USER
export CUBEJS_DB_PASS=$DRIVERS_TESTS_SNOWFLAKE_CUBEJS_DB_PASS

yarn lerna run --concurrency 1 --stream --no-prefix smoke:snowflake

Expand Down
130 changes: 0 additions & 130 deletions .github/workflows/cloud.yml
View file
Open in desktop

This file was deleted.

20 changes: 20 additions & 0 deletions .github/workflows/push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
push:
paths:
- '.github/actions/smoke.sh'
- '.github/actions/integration/**'
- '.github/workflows/push.yml'
- '.github/workflows/master.yml'
- 'packages/**'
Expand All @@ -23,6 +24,8 @@ on:
- 'master'
pull_request:
paths:
- '.github/actions/smoke.sh'
- '.github/actions/integration/**'
- '.github/workflows/push.yml'
- '.github/workflows/master.yml'
- 'packages/**'
Expand Down Expand Up @@ -389,6 +392,9 @@ jobs:
if: (needs['latest-tag-sha'].outputs.sha != github.sha)
env:
CLOUD_DATABASES: >
athena
bigquery
snowflake
firebolt
dremio
# Athena (just to check for secrets availability)
Expand All @@ -398,6 +404,7 @@ jobs:
matrix:
node-version: [22.x]
db: [
'athena', 'bigquery', 'snowflake',
'clickhouse', 'druid', 'elasticsearch', 'mssql', 'mysql', 'postgres', 'prestodb',
'mysql-aurora-serverless', 'crate', 'mongobi', 'firebolt', 'dremio', 'vertica'
]
Expand Down Expand Up @@ -449,6 +456,8 @@ jobs:
retry_wait_seconds: 15
timeout_minutes: 20
command: yarn install --frozen-lockfile
- name: Build Core Client libraries
run: yarn build
- name: Lerna tsc
run: yarn tsc
- name: Run Integration tests for ${{ matrix.db }} matrix
Expand All @@ -475,6 +484,17 @@ jobs:
DRIVERS_TESTS_DREMIO_CUBEJS_DB_NAME: ${{ secrets.DRIVERS_TESTS_DREMIO_CUBEJS_DB_NAME }}
DRIVERS_TESTS_DREMIO_CUBEJS_DB_DREMIO_AUTH_TOKEN: ${{ secrets.DRIVERS_TESTS_DREMIO_CUBEJS_DB_DREMIO_AUTH_TOKEN }}

# BigQuery
DRIVERS_TESTS_SNOWFLAKE_CUBEJS_DB_BQ_CREDENTIALS: ${{ secrets.CUBEJS_DB_BQ_CREDENTIALS }}

# AWS Athena
DRIVERS_TESTS_SNOWFLAKE_CUBEJS_AWS_KEY: ${{ secrets.CUBEJS_AWS_KEY }}
DRIVERS_TESTS_SNOWFLAKE_CUBEJS_AWS_SECRET: ${{ secrets.CUBEJS_AWS_SECRET }}

# Snowflake
DRIVERS_TESTS_SNOWFLAKE_CUBEJS_DB_USER: ${{ secrets.DRIVERS_TESTS_CUBEJS_DB_SNOWFLAKE_USER }}
DRIVERS_TESTS_SNOWFLAKE_CUBEJS_DB_PASS: ${{ secrets.DRIVERS_TESTS_CUBEJS_DB_SNOWFLAKE_PASS }}

integration-smoke:
needs: [latest-tag-sha, build-cubestore, build-native-linux]
runs-on: ubuntu-24.04
Expand Down