Skip to content

feat: Allow additional filters in PatchMeasure for number measures #9468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mcheshkov
Copy link
Member

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

Additional filters for number measures should be propagated to leaf measures
And only leaf number measures should trigger an error
Supported only in Tesseract

Copy link

codecov bot commented Apr 14, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.56%. Comparing base (91e3af6) to head (898c75a).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
.../cubejs-schema-compiler/src/adapter/BaseMeasure.ts 0.00% 1 Missing ⚠️
rust/cubesql/cubesql/src/transport/ext.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9468      +/-   ##
==========================================
- Coverage   83.89%   76.56%   -7.33%     
==========================================
  Files         229      400     +171     
  Lines       83544   104995   +21451     
  Branches        0     3723    +3723     
==========================================
+ Hits        70087    80390   +10303     
- Misses      13457    24173   +10716     
- Partials        0      432     +432     
Flag Coverage Δ
cube-backend 48.03% <0.00%> (?)
cubesql 83.89% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant