Skip to content

Enabled multi-selection support for several commands #2620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

sebjulliand
Copy link
Collaborator

@sebjulliand sebjulliand commented Apr 19, 2025

Changes

As discussed here: https://github.com/orgs/codefori/discussions/2612

This PR enables multi-selection support for the following commands:

  • Generate binder source
  • Browse/edit members
  • Browse/edit IFS files
  • Maintain filter
  • Custom actions
  • Search source file
  • Search in IFS
  • Find in IFS

Run multiple custom actions

Some noticeable changes were done to allow running custom actions on multiple items.

  • All the selected items must share the same nature (i.e. URI scheme) (otherwise a warning is shown)

  • If the command must be prompted , it will do so for each item:

    • If the action is run on a single item, it will be prompted as usual
    • If the action is run on multiple items, it will be prompted once, keeping the variables placeholders
  • The whole execution can now be cancelled. It will stop the process after the current item is done being processed
    image

  • The output webview had been enhanced to display multiple outputs. The left side displays items' path and the right side shows the selected item output. The icon in front of the item shows the execution result (ok, failed or not run).
    image

  • Running an action on a single item will only show the single output (no need for navigating through multiple results)

Search in members / Search/find in streamfiles

Finding or searching can be cancelled. The search will stop after the current path is done being processed.
Once a path has been processed, the results are added to the Search Results view, which means the view gets populated dynamically while the search is running.

How to test this PR

  1. Use ctrl+click or shift+click to select multiple items in the Object browser or IFS browser
  2. Check that actions are consistently shown
  3. The the actions mentioned in the description

Checklist

  • have tested my change

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand sebjulliand added the enhancement New feature or request label Apr 19, 2025
@sebjulliand sebjulliand requested a review from a team April 19, 2025 10:16
@sebjulliand sebjulliand self-assigned this Apr 19, 2025
@sebjulliand sebjulliand temporarily deployed to testing_environment April 19, 2025 10:16 — with GitHub Actions Inactive
Copy link
Contributor

github-actions bot commented Apr 19, 2025

👋 A new build is available for this PR based on 37f4714.

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand sebjulliand deployed to testing_environment April 19, 2025 12:34 — with GitHub Actions Active
@sebjulliand
Copy link
Collaborator Author

Edit: on second thought, prompted custom actions should be prompted once and executed many times instead of prompting each item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant