-
Notifications
You must be signed in to change notification settings - Fork 30
Generate RPG data structure from result metadata #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment about moving logic to another function.
I don't want the logic to generate the content in this function really. We should move it elsewhere so we can write test cases for it.
Please make this change and then lmk when to look again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left another review.
@worksofliam : Where do you want the tests? A new testsuite? Please continue to comment if you want me to change something else :) I will continue working on this tomorrow |
@janfh For my own sake of mind, I have had to move this to fix day 2 (Wednesday 23rd) and this will be the first PR I look at then. I may get to it over the weekend if I find a moment. Thanks for your work here! Also, let's chat on chat.ibmioss.org sometime. |
@janfh Is there any reason you aren't using this switch (statementDetail.qualifier) { |
@worksofliam : I think it was to avoid changing that runSql on 405. But I can change this if you like. I guess there is no reason why we can't always use the runSqlVerbose? |
@janfh i guess Going to do some final tests in the morning on this one and it should be good to go. |
Feature to generate RPG data structure from column metadata.
Added statement qualifier "rpg". E.g:
generates: