Complete rewrite to make adding features and fixes easier #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s that require it
There was a problem hiding this comment.
Pull Request Overview
A complete rewrite aimed at simplifying the addition of new features and fixes, with special adjustments for firmware version 7.x that require ECDH key encryption.
- New CLI implementation with enhanced terminal output and progress indicators
- Removal of the lib/api.js module as part of streamlining the codebase
- Updated documentation, license files, and CI/CD workflow configurations
Reviewed Changes
Copilot reviewed 73 out of 85 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/cli/src/cli.ts | Introduces new CLI functions with improvements in output |
| packages/cli/README.md | Updates usage instructions and options for the CLI |
| packages/cli/LICENSE.md | Adds ISC license information |
| lib/api.js | Removes obsolete API module |
| README.md | Revamps project documentation and command help details |
| LICENSE.md | Adds ISC license information |
| .github/workflows/npm-publish.yml | Upgrades GitHub Actions configurations and Node.js versions |
Files not reviewed (12)
- .npmignore: Language not supported
- .prettierrc: Language not supported
- .vscode/extensions.json: Language not supported
- .vscode/settings.json: Language not supported
- Dockerfile: Language not supported
- VERSION: Language not supported
- certs/ca.crt: Language not supported
- certs/server.crt: Language not supported
- mosquitto/basic.conf: Language not supported
- package.json: Language not supported
- packages/cli/.npmignore: Language not supported
- packages/cli/package.json: Language not supported
| }; | ||
|
|
||
| /** | ||
| * Draws a spinner and a message that is updated on success or failire |
There was a problem hiding this comment.
Typo found in the comment: 'failire' should be corrected to 'failure'.
Suggested change
| * Draws a spinner and a message that is updated on success or failire | |
| * Draws a spinner and a message that is updated on success or failure |
Copilot uses AI. Check for mistakes.
| --wifi-pass <wifi-pass> WIFI Access Point password | ||
| --wifi-encryption <wifi-encryption> WIFI Access Point encryption (this can be found using meross info --include-wifi) | ||
| --wifi-cipher <wifi-cipher> WIFI Access Point cipher (this can be found using meross info --include-wifi) | ||
| --wifi-bssid <wifi-bssid> WIFI Access Point BSSID (each octet seperated by a colon `:`) |
There was a problem hiding this comment.
Typo in the README: 'seperated' should be corrected to 'separated'.
Suggested change
| --wifi-bssid <wifi-bssid> WIFI Access Point BSSID (each octet seperated by a colon `:`) | |
| --wifi-bssid <wifi-bssid> WIFI Access Point BSSID (each octet separated by a colon `:`) |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete rewrite to make adding features and fixes easier
Added fixes for firmware versions 7.x which require certain actions to be encrypted with a ECDH derived key.